make native JavaScript conditions available, decrease polling frequency for long running actions#5
Open
pbruski wants to merge 1 commit into
Conversation
pbruski
changed the title
pbruski
force-pushed
the
make-native-JavaScript-conditions-available,-decrease-polling-frequency-for-long-running-actions
branch
from
40f8af8 to
3faaa58
Compare
wyrzyk
previously approved these changes
Feb 12, 2020
dagguh
reviewed
Feb 12, 2020
| api("com.github.stephenc.jcip:jcip-annotations:1.0-1") | ||
| api(webdriver("selenium-api")) | ||
|
|
||
| implementation("com.atlassian.performance:selenium-js:[1.0.0,2.0.0)") |
Contributor
There was a problem hiding this comment.
What's the upside of including a unused lib?
Author
There was a problem hiding this comment.
I want to make it available to people who depend on jira-software-actions to promote best practices.
Contributor
There was a problem hiding this comment.
Then do jira-software-actions fail to use the best practices?
Author
There was a problem hiding this comment.
:-) With the amount of polling in jsa, it does not make sense to switch to the native conditions.
…cy for long running actions
pbruski
force-pushed
the
make-native-JavaScript-conditions-available,-decrease-polling-frequency-for-long-running-actions
branch
from
3faaa58 to
60f207b
Compare
dagguh
suggested changes
Sep 29, 2020
Contributor
dagguh
left a comment
dagguh
left a comment
There was a problem hiding this comment.
Unused libs should be avoided. There are better promotion channels of "using this lib is good for you".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.