Skip to content

make native JavaScript conditions available, decrease polling frequency for long running actions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbruski wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make native JavaScript conditions available, decrease polling frequency for long running actions #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ Dropping a requirement of a major version of a dependency is a new contract.

## [Unreleased]
[Unreleased]: https://github.com/atlassian/jira-software-actions/compare/release-1.3.2...master

### Added
- Native JavaScript Selenium conditions are now available
### Changed
- decreased polling frequency
### Fixed
- Reduce the overhead of handling large boards and backlogs
- Upgrade Selenium to 3.141.59
Expand Down
1 change: 1 addition & 0 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ dependencies {
api("com.github.stephenc.jcip:jcip-annotations:1.0-1")
api(webdriver("selenium-api"))

implementation("com.atlassian.performance:selenium-js:[1.0.0,2.0.0)")
Copy link
Copy Markdown
Contributor

@dagguh dagguh Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the upside of including a unused lib?

Copy link
Copy Markdown
Author

@pbruski pbruski Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to make it available to people who depend on jira-software-actions to promote best practices.

Copy link
Copy Markdown
Contributor

@dagguh dagguh Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then do jira-software-actions fail to use the best practices?

Copy link
Copy Markdown
Author

@pbruski pbruski Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) With the amount of polling in jsa, it does not make sense to switch to the native conditions.

implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlinVersion")
implementation("org.glassfish:javax.json:1.1")
implementation(webdriver("selenium-support"))
Expand Down
1 change: 1 addition & 0 deletions gradle/dependency-locks/compileClasspath.lockfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# Manual edits can break the build and are not advised.
# This file is expected to be part of source control.
com.atlassian.performance.tools:jira-actions:3.10.2
com.atlassian.performance:selenium-js:1.0.1
com.github.stephenc.jcip:jcip-annotations:1.0-1
com.google.code.findbugs:jsr305:1.3.9
com.google.errorprone:error_prone_annotations:2.1.3
Expand Down
1 change: 1 addition & 0 deletions gradle/dependency-locks/testCompileClasspath.lockfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# This file is expected to be part of source control.
com.atlassian.performance.tools:docker-infrastructure:0.3.2
com.atlassian.performance.tools:jira-actions:3.10.2
com.atlassian.performance:selenium-js:1.0.1
com.github.stephenc.jcip:jcip-annotations:1.0-1
com.google.code.findbugs:jsr305:1.3.9
com.google.errorprone:error_prone_annotations:2.1.3
Expand Down
3 changes: 2 additions & 1 deletion ...in/kotlin/com/atlassian/performance/tools/jirasoftwareactions/api/page/ViewBacklogPage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ class ViewBacklogPage(
) {
fun waitForBacklog() = driver.wait(
Duration.ofSeconds(30),
presenceOfElementLocated(By.cssSelector("#ghx-backlog[data-rendered]:not(.browser-metrics-stale)"))
presenceOfElementLocated(By.cssSelector("#ghx-backlog[data-rendered]:not(.browser-metrics-stale)")),
Duration.ofMillis(100)
)

fun getIssueKeys(): List<String> {
Expand Down
3 changes: 2 additions & 1 deletion ...main/kotlin/com/atlassian/performance/tools/jirasoftwareactions/api/page/ViewBoardPage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ class ViewBoardPage(
) {
fun waitForBoard() = driver.wait(
Duration.ofSeconds(30),
presenceOfElementLocated(cssSelector(".ghx-column"))
presenceOfElementLocated(cssSelector(".ghx-column")),
Duration.ofMillis(100)
)

fun getIssueKeys(): List<String> {
Expand Down