Draft
Conversation
French format_o was returning the bare day number instead of adding a suffix like other language modules. Now returns "1e", "15e" etc. consistent with Dutch, Swedish, Finnish, Russian. Note: French convention is technically "1er" for the first day, but this matches the simplified approach used by most language modules in this distribution. Originally submitted as gbarr#16 by @mitchjacksontech Co-Authored-By: mitchjacksontech <mitchjacksontech@users.noreply.github.com>
atoomic
reviewed
Feb 26, 2026
| @MoY = qw(janvier f�vrier mars avril mai juin | ||
| juillet ao�t septembre octobre novembre d�cembre); | ||
| @MoY = qw(janvier f�vrier mars avril mai juin | ||
| juillet ao�t septembre octobre novembre d�cembre); |
Owner
There was a problem hiding this comment.
looks like we have an encoding issue here
atoomic
requested changes
Feb 26, 2026
Owner
|
@Koan-Bot rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
format_oinDate::Language::Frenchto include day ordinal suffix.Why
Migrated from gbarr/perl-TimeDate#16 (originally submitted 2019-01-30 by @mitchjacksontech). The French module's
format_owas returning bare day numbers while all other language modules add language-appropriate suffixes.Changes
lib/Date/Language/French.pm:format_onow returnssprintf("%2de", day)instead of just the day numberNote
French convention is technically "1er" for the 1st, but this simplified approach ("1e") is consistent with Dutch, Swedish, Finnish, and Russian modules.
🤖 Migrated by Kōan from gbarr#16