This repository was archived by the owner on Feb 26, 2026. It is now read-only.
Fix for French language using English day suffixes#16
Open
mitchjacksontech wants to merge 1 commit intogbarr:nextfrom
Open
Fix for French language using English day suffixes#16mitchjacksontech wants to merge 1 commit intogbarr:nextfrom
mitchjacksontech wants to merge 1 commit intogbarr:nextfrom
Conversation
mitchjacksontech
commented
Jan 30, 2019
mitchjacksontech
commented
atoomic
reviewed
Jan 13, 2020
| sub format_B { $MoY[$_[0]->[4]] } | ||
| sub format_h { $MoYs[$_[0]->[4]] } | ||
| sub format_p { $_[0]->[2] >= 12 ? $AMPM[1] : $AMPM[0] } | ||
| sub format_o { sprintf("%2de",$_[0]->[3]) } |
There was a problem hiding this comment.
a better French fix will be to do not use the suffix as it s not very common
The current suggested fix will be wrong in several cases
for example: 1st should be 1er,
then after ème is better than e for every other enumeration ....
Author
There was a problem hiding this comment.
Not being French myself, I defer to you and wikipedia, the better fix is do not use the suffix.
Will update the pull request accordingly
Koan-Bot
added a commit
to Koan-Bot/perl-TimeDate
that referenced
this pull request
Feb 26, 2026
French format_o was returning the bare day number instead of adding a suffix like other language modules. Now returns "1e", "15e" etc. consistent with Dutch, Swedish, Finnish, Russian. Note: French convention is technically "1er" for the first day, but this matches the simplified approach used by most language modules in this distribution. Originally submitted as gbarr#16 by @mitchjacksontech Co-Authored-By: mitchjacksontech <mitchjacksontech@users.noreply.github.com>
Migration NoticeThis repository is no longer actively maintained. The official source has moved to atoomic/perl-TimeDate. This PR has been migrated to the new repository: Thank you @mitchjacksontech for the original contribution! 🤖 Automated migration by Kōan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.