Repository navigation
Conversation
|
Thanks for getting the J616c camera streaming. A few parts don't fit how we usually structure this. The ISP power-up skip grows a chip list (
format-check also fails on |
|
Adding a few points to the earlier review, not repeating it:
|
ae9ef78 to
70455e9
Compare
|
Thanks for the review! Updated the branch (
|
|
Thank you for the careful rework: the tree-driven ISP gate, the single placeholder fill, the |
…skip property-driven
Select ISP loader power-up and firmware segment handoff from the kernel
device tree and ADT properties rather than per-chip ID lists:
- Gate isp_init() on isp_fdt_needs_init(fdt) so trees whose ISP node is
disabled, carries /reserved-memory/isp-firmware-{text,data}
placeholders, or binds a kernel-owned compatible (apple,t8132-isp,
apple,t6041-isp on T6040/T6041, apple,t6050-isp) skip loader power-up.
- Unify dt_set_isp(), dt_set_isp_fwdata(), and dt_finish_j614s_isp() onto
a single placeholder-driven dt_fill_isp_placeholders() path for every
tree with isp-firmware-{text,data} placeholders, deriving the firmware
IOVA window from ADT dart-isp vm-base and /reserved-memory/isp-heap
iommu-addresses (32 MiB on T6040/T6041, below the kernel's shared DMA
allocations).
- Reuse dapf.c's struct dapf_t8110_config parser via dapf_t8110_ranges()
to sync isp_dart0 apple,dapf-ranges from ADT dapf-instance-0 across
6-AMCC and 8-AMCC dies, logging an error and failing closed if
dapf-instance-0 is missing or malformed.
Signed-off-by: Artyom Astafurov <artyom.astafurov@gmail.com>
The J713 AOP and ISP DAPF tests disable the inverted-slice check by rewriting its source text, "config[i].end < config[i].start". The DAPF parser now copies each packed record before checking it (entry.end < entry.start), so the rewrite no longer matched and both tests failed their own mutation control. Point it at the new spelling; the control again proves an inverted slice is refused. Signed-off-by: DjDeveloperr <hey@djdev.me>
70455e9 to
22f1225
Compare
|
Added 22f1225 (tests only): #309's |
|
Review of 22f1225 (your commit rebased onto main, plus the tests-only commit), from the angle of boards other than the J616c. Device-tree references are to linux
Smaller points:
Local checks on 22f1225 (aura Actions macOS runners are still stuck) are in the next comment. |
|
Local checks on 22f1225. All 14 Actions jobs on this head are still queued (runner outage), so these were run by hand: clang-format 20.1.8 (the PR's files and |
Make ISP preloaded-segment handoff,
dart-isp0DAPF range sync, and Stage 2 ISP power-up skipping property-driven instead of gating on per-SoC chip lists:src/isp.c/src/kboot.c: Replace thechip_idlist inisp_init()withisp_fdt_needs_init(fdt)so Stage 2 skips legacyisp_init()whenever the FDT'sispnode is absent/disabled, uses/reserved-memory/isp-firmware-{text,data}placeholders, or bindsapple,t8132-isp/apple,t6041-isp(T6040/T6041) /apple,t6050-isp.src/kboot.c(dt_set_isp_fwdata()): UnifyJ614sandT6040/T6041segment fill into a single placeholder-drivendt_fill_isp_placeholders()path for any tree carryingisp-firmware-{text,data}placeholders, deriving the remap window from ADTdart-ispvm-baseand FDTisp-heapiommu-addresses(32 MiBonT6040/T6041, below Linux's shared DMA allocations).src/dapf.c(dapf_t8110_ranges()): Reusestruct dapf_t8110_configto parsedapf-instance-0instead of open-coding 52-byte records inkboot.c, and log + fail closed (disablingispand its placeholders) ifdapf-instance-0is missing, has an unexpected length, or has inverted bounds.Companion PRs
aurora-silicon/linux): media: apple: isp, arm64: dts: support 8-AMCC T6041 and NV12 LIM_RANGE linux#2216aurora-silicon/camera-denoise): config, main, data: key camera profiles on sysfs sensor name ([sensor:imx958-uw]) camera-denoise#14Still to do
apple/isp_2224_01XX.dat) for packaging alongside firmware.