Repository navigation
Conversation
Enable camera support on full-die 8-AMCC T6041 parts (J616c) and fix NV12 quantization metadata: - Add AMCC 6 (0x22c004000..0x22c1d62fc) and AMCC 7 (0x22e004000..0x22e1d62fc) to &isp_dart0 in t6041.dtsi. - Add apple_isp_hw_t6041 in isp-drv.c. The driver counts active AMCC ranges on isp_dart0 and sizes fw_mmio and DSID broadcast-clear windows to match. This supports 6-AMCC binned and 8-AMCC full-die T6041 chips across >5 s runtime power-off reopen cycles. - Set V4L2_QUANTIZATION_LIM_RANGE on NV12 in isp-v4l2.c to match P010, and update isp-v4l2-test.c. Signed-off-by: Artyom Astafurov <artyom.astafurov@gmail.com>
Expose a read-only 'sensor' sysfs attribute on the apple-isp platform device (/sys/class/video4linux/videoX/device/sensor) backed by canonical sensor module names in isp_setfiles[] (such as "imx958-uw" for the 12 MP Center Stage ultra-wide IMX958 module and "imx558" for IMX558). On hardware with deferred camera startup, sensor_show() returns -ENODATA until the first stream detects the camera, then emits the detected sensor identifier under video_lock so userspace services can select tuning and framing capabilities by sensor property rather than per-board lists. Signed-off-by: Artyom Astafurov <artyom.astafurov@gmail.com>
Contributor
Author
|
Added a second commit ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: Please merge after #1954.
This branch starts from
integration/auroraand merges cleanly on top of#1954with zero conflicts.Companion PRs:
aurora-silicon/aura): isp, dapf, kboot: make ISP placeholder handoff, DAPF sync, and power skip property-driven aura#304aurora-silicon/camera-denoise): config, main, data: key camera profiles on sysfs sensor name ([sensor:imx958-uw]) camera-denoise#14Summary
This series enables
apple-ispcamera streaming on 8-AMCCT6041(J616c, MacBook Pro 16" M4 Max), fixesNV12quantization metadata, and exposes the detected camera sensor module name in sysfs:media: apple: isp, arm64: dts: support 8-AMCC T6041 and NV12 LIM_RANGE(4749bc96f242):0x22c004000..0x22c1d62fc) and AMCC 7 (0x22e004000..0x22e1d62fc) filter ranges to&isp_dart0int6041.dtsi.apple_isp_hw_t6041: count active AMCC ranges onisp_dart0and sizefw_mmioand DSID broadcast-clear windows to match, supporting both 6-AMCC binned and 8-AMCC full-dieT6041chips across>5 sruntime power-off and reopen cycles.V4L2_QUANTIZATION_LIM_RANGEonNV12inisp-v4l2.cto matchP010, and updateisp-v4l2-test.c.media: apple: isp: expose detected camera sensor name in sysfs(b4018aeb078d):sensorattribute on theapple-ispplatform device (/sys/class/video4linux/videoX/device/sensor, documented inDocumentation/ABI/testing/sysfs-driver-apple-isp) backed by canonical sensor module names inisp_setfiles[](such as"imx958-uw"and"imx558").-ENODATAprior to deferred camera startup so userspace (aurora-silicon/camera-denoise#14) can key low-light thresholds and framing capabilities on sensor identity rather than board lists.Testing
./scripts/checkpatch.pl --strictreports0 errors, 0 warnings, 0 checks.tools/asahi/run-host-tests.py --only isp-:18 / 18suites passed (includingisp_test_sensor_namesandisp_test_sensor_sysfs).J616c(M4 Max, 8 AMCCs) verifiesNV12andP010capture at1920x1080@30, runtime power-down and reopen (>6 sidle), and zero DART faults.Still to do
aurora-installerextract the sensor tuning file (apple/isp_2224_01XX.datfrom/usr/libexec/appleh16camerad) into/lib/firmware/apple/on first boot.