Repository navigation
soc: apple: sep: add biometric application key operations - #1004
Closed
cameroncooper wants to merge 7 commits into
Closed
cameroncooper wants to merge 7 commits into
cameroncooper wants to merge 7 commits into
Conversation
Bind signing policies to a biometric credential set and construct the extended image-init request that authorizes that set. Sort key-store dictionary members by their full encoding so nested access-control policies match the native serializer. Include synthetic known-answer coverage for policy encoding, member ordering and credential capture fields.
Match into a fresh kernel-owned credential and delete it before publishing a signature. Reserve operation ownership across cancellation, close and synchronous key calls so concurrent ioctls cannot overlap the shared key-store session. Include focused lifecycle checks.
Expose ECIES decryption and an explicit capability flag while retaining the signing ABI. Match each request into a fresh credential, wipe canceled or expired plaintext, and use a condition-variable deadline wait instead of periodic worker polling. Extend lifecycle tests for both operation types and undelivered output.
cameroncooper
marked this pull request as draft
November 5, 2026 20:00
RyanTheTide
reviewed
Nov 9, 2026
RyanTheTide
left a comment
Contributor
There was a problem hiding this comment.
Two things are needed before this can be merged:
- These commits have no Signed-off-by line: de635fd, fb3d004, 19134cc, 8a85d23, 9ed2e3a, 4780d77, 239f949, 2a4f488, 7d805d1, bf06a25, 8b64787, 879b3b1, b926201, f01b2a8, 1475757, 53d1ab3, 3fc257f, 6180a47, 8ea5bd6. Please add them.
- The base
feat/sepis far behind. Please rebase onto integration/aurora and retarget the PR there. A test merge conflicts indrivers/soc/apple/{bio.rs,pm.rs,pm_shim.c,profile.rs,sbio.rs,Kconfig,Makefile}and several board DTs (t6000-j314s, t6001-j314c, t6001-j316c, t6021-j414c, t8112-j413).
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing SEP interface supports fingerprint verification and attestation with a fixed machine key. This adds application-owned P-256 keys with biometric-authorized signing and ECIES item decryption.
Applications persist an opaque wrapped key blob and public key. Each operation matches a fingerprint into a fresh kernel-owned authentication context, performs the requested operation, and deletes the context before publishing success. The private key stays inside SEP; item decryption returns plaintext to the requesting process.
The change includes:
The interface is additive to biometric ABI version 4 and remains root-only and exclusive. Support is limited to the validated key-store protocol; other profiles fail closed. Private-key import, P-384, application authorization and vault migration are outside this change.
Validation
Hardware regression passed on J293/M1 with the final driver artifact loaded after a warm reboot:
Keychain application integration was separately validated against the preceding working implementation. The final regression did not modify the keychain application or its data. Hardware results are from J293/M1.