Repository navigation
soc: apple: sep: fail key operations when credential disposal fails - #2048
Open
cameroncooper wants to merge 1 commit into
Open
cameroncooper wants to merge 1 commit into
cameroncooper wants to merge 1 commit into
Conversation
This was referenced Nov 16, 2026
Author
|
@RyanTheTide, could you approve CI on #2048–#2051? They're my first PRs here, so They replace #1004, retargeted to |
A password-authorized sign or unseal creates an unlock evaluation in the enclave and deletes it afterwards. The deletion's answer was ignored, so a result could be returned while the credential context it was authorized by might still be live. Confirm the deletion before a result leaves the driver, and discard the result if it fails. An unconfirmed deletion latches key operations off until the driver restarts (a reboot or a module reload), so nothing later runs against a context that may still hold the credential; capability queries and cancellation stay available meanwhile. The KUnit cases and the host test run the production guard for success, early exits and a failed deletion, checking that the result is destroyed and that deletion is attempted exactly once. Assisted-by: LLM [Claude Code, claude-opus-5-5] Signed-off-by: Cameron Cooper <c@meron.cc>
cameroncooper
force-pushed
the
review/sep-disposal-fail-closed
branch
from
November 16, 2026 20:23
fd781ee to
7723f3d
Compare
cameroncooper
marked this pull request as ready for review
November 16, 2026 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A password-authorized
SEP_KEY_SIGN_PASSWORDorSEP_KEY_UNSEAL_PASSWORDcreates an unlock evaluation in the enclave and deletes it afterwards. The deletion's answer was ignored, so a result could be returned while the credential context it was authorized by might still be live.This confirms the deletion before a result leaves the driver and discards the result if it fails. An unconfirmed deletion latches private key operations off until the driver restarts (a reboot or module reload);
SEP_KEY_GET_INFOandSEP_KEY_CANCELstay available. This is the "unconfirmed credential disposal" case that warrants a quarantine; ordinary refusals, misses and cancellations are unaffected.Tests
apple_sep_key_one_op): two new cases drive the production guard for success, early exits and a failed deletion, checking that the result is destroyed and that deletion is attempted exactly once.tools/aurora-sep/tests/test_key_context_cleanup.py(same pattern astest_refkey_seal_admission.py), added to thesep-sourceworkflow.test_log_ratelimit.pypasses; the module builds for arm64 with no new warnings.Hardware
🤖 Generated with Claude Code