Skip to content

K116s: SEP profile, ISP camera log line, tas2764 brownout log level - #1649

Merged
RyanTheTide merged 3 commits into
aurora-silicon:integration/aurorafrom
sithglan:thomas/k116s-drivers
Nov 12, 2026
Merged

RyanTheTide merged 3 commits into
aurora-silicon:integration/aurorafrom
sithglan:thomas/k116s-drivers

Conversation

@sithglan

@sithglan sithglan commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Base: integration/aurora (050f6a5). Three small driver commits for the K116s:

Tested by Jens on the K116s (27.2, 26B8125). For the ISP commit his message says "Compiled (clang 21, arm64); not run".

Build: arm64, LLVM 22, Rust. drivers/soc/apple/, drivers/media/platform/apple/isp/ and sound/soc/codecs/tas2764.o build. The only warnings are the existing dead-code ones in apple-sep's key.rs/control.rs.

Authorship. Jens Axboe wrote these commits and runs them on his K116s (16-inch MacBook Pro, M5 Pro, OLED; Mac17,12; stub macOS 27.2 26B8125). They come from his K116s bundle of 2026-11-11 (integration/aurora 254c9bd plus 34 commits, kernel 7.3.0 running on the machine). I rebased them onto integration/aurora 050f6a5 and removed the LLM co-author and session trailers. Jens has given his OK: the commits carry his Signed-off-by.

The K116s ADT describes the J714s's SEP: an iop-sep,ascwrap-v6 SEP left
booted by iBoot, dart-sep with vm-base-0 0x10000004000 and vm-size-0
0xffff0000, and the Mesa sensor (sensor-id V3) on spi2 at 0x505108000.
With the profile the SEP attaches, provisions the identity keybag and
registers the trusted-key source on the K116s.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
Detection logs nothing unless it fails: the sensor the firmware found is
only a dev_dbg(). On a machine whose camera is detected at the first
stream (T6050), a stream that then fails leaves no record of whether
the firmware answered at all, which sensor it reported or which setfile
the driver will ask for.

Print one line when the camera is detected: the sensor version, the
number of sensor configurations the firmware has, the platform ID the
loader passed and the setfile.

Compiled (clang 21, arm64); not run.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
A missing brownout configuration is the normal case on these boards; say
so at debug level.

Signed-off-by: Jens Axboe <axboe@kernel.dk>

@RyanTheTide RyanTheTide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the three commits. The SEP profile match is gated on both compatibles and has a test, the ISP line indexes the setfile table only after the sensor id is validated and runs once per detection, and the tas2764 change is a log level. Looks good.

@RyanTheTide
RyanTheTide merged commit 2ed8074 into aurora-silicon:integration/aurora Nov 12, 2026
7 checks passed
chrisohearn added a commit to chrisohearn/omarchy-m5p-oled that referenced this pull request Nov 17, 2026
) (#174)

- patches/linux/sep/0001: apple,k114s joins the T6050 SEP profile match
  (the form aurora-silicon/linux#1649 used for the K116s), with its KUnit
  case. patches/linux/r3b-c4.series is r3b.c3 plus it.
- PKGBUILD takes K114S_CAND=r3b-c4 (version 7.3.0.r3b.c4-1, upgrades
  r3b.c3 in place) and refuses a tree without the profile line;
  check-package.sh checks apple-sep names apple,k114s from r3b.c4.
- dts/t6050-k114s-r3b-touchid.dts: the booted brightness tree plus the
  Touch ID fragment, nothing else. tests/test-touchid-dtb.sh now checks
  that delta exactly.
- docs: the owner's decisions, the build record (r3b-kernel section 12),
  and the trial, read-only load, backup and enrolment steps.

Built and checked on the Mac; not booted. Nothing writes Secure Enclave
state: apple_sep is not loaded by anything, and aurora-sep's options keep
a load read-only.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants