Repository navigation
Conversation
A T8132 main DCP wired to fixed HDMI uses six firmware segments and shares the retained SID 0/SID 16 frontend contract with the external display path. Qualify that layout from the available main DCP and its connector role. Validate its physical framebuffer separately from inherited mappings and preserve both frontend streams without a board-name gate. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
Some T8132 desktops route the main DCP through a fixed DPTX-to-HDMI path instead of an internal panel. Use the connector-type property as that role contract, prepare the PHY and converter rails, adopt the retained firmware session, and register it through the external-output KMS path. Accept the retained physical framebuffer without manual bind controls or machine-name checks. Use a J773g M4 profile without panel timing and continue to refuse machines without a profile. J773g does not use the J713 panel admission parameters because the external path skips apple_pmp_j713_display_prepare() and has no internal panel timing or panel power admission. Keep an empty external device from replacing simpledrm, and retain an adopted session when its initial HDMI DPTX connect fails. The external KMS layer still caps the device at two outputs, so two adopted dcpext outputs leave the fixed HDMI output unregistered. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
T8122 (as used on T8132) needs its own cold activation: the T8112 core power steps, moved enable/clear bits (0x2218, 0x2234), a different 0x2230 setting, no 0x4008/0x420c/0x4404/0x4408/0x4600 steps, and an AUX impedance calibration whose result is copied into 0x4228. At link-rate change it clears 0x222c bit 1 instead of 0x2220 bit 7, takes the T6020 settings for 0x20b0, the first 0x20b4 write and 0x20b8 bit 16, then clears 0x20b4 bit 1 and skips the 0x20b8 bit 21 clear. For T8122 only, enable runtime PM before creating the PHY so the generic PHY core propagates runtime-PM references to the provider. The T8112, T6020 and T6050 paths are unchanged. Link: GravityLinux/linux@877c574 Assisted-By: OpenAI Codex (GPT-5.6 Sol) Signed-off-by: Niklas Sheth <hi@niklassheth.com> [Sean: extracted the T8122 hunk; rebased over T6050; runtime PM for T8122 only; calibration code from the readback] Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
The Mac mini routes its main DCP through the T8122 DPTX PHY and an HDMI converter controlled by two SMC GPIOs. Describe that fixed path and enable the retained DCP, mailbox, and display DART nodes. Do not attach the DCP or mailbox to DISP_CPU: iBoot leaves that domain in auto mode and direct PMGR writes fault on this machine. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
Name and order the existing T8122 DPTX PHY register windows as core and dptx to match the driver and binding. Assisted-by: LLM Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
With only the HDMI path described, the Mac mini still has no display: - The DPTX PHY sits on ps_dptx_phy, which the J713 PMGR policy (applied to every M4 board that does not state the domain) keeps from Linux. phy-apple-dptx and the DCP behind it wait for it until the deferred probe timeout (-110). State the domain for this board, as it already does for the ATC2 and ATC3 domains. - The DCP's PIODMA child owns iommu-addresses entries in /reserved-memory, so the DCP node needs #address-cells and #size-cells; the display DART's admission otherwise warns that both are missing. - The loader and the display DART look the PIODMA stream up by the disp0_piodma alias, as on T8122; add it. Assisted-by: LLM Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
The T8122 driver maps its core and DPTX windows by name. Require those resource names for DPTX PHY nodes. Assisted-by: LLM Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
|
One corrected-config boot on our J773g exercised signed head |
Describe the T8122 DPTX PHY register layout used by the J773g HDMI stack, stacked on draft PR #1192.
The binding now requires the
coreanddptxregister names. The DTS patch names and orders the existing T8122 register windows accordingly. This is a binding-only / DTS-description change; it does not change runtime code and has no hardware boot of its own.Dependency: this series is intentionally stacked on #1192 head
700491843df09e2a8c2182215769025609895d5a, whose T8122 PHY node consumes this binding. The dependent PHY implementation commit39d81c9ac9a1remains Niklas Sheth's original commit with its original trailers.Validation:
a829ccde195d7db1d0125a6fd558dea608be98eepassedagents/m4 pr-checkwith zero reported warnings;195fbc7a1a9289164f1766665cc743d98fd4c82b941c475ef690a5a87da4daf2;apple/t8132-j773g.dtbis SHA-256de99bb21c4131b453bbb662aa97e9c6f9429c1e3086045dff427a9de1618f04d;make ARCH=arm64 DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/apple,dptx-phy.yaml dt_binding_checkpassed with dtschema 2026.9.Full-tree schema validation was not run because the tree has a known existing
apple,tunabletype crash. No separate J773g boot is claimed.Assisted-by: LLM