Repository navigation
Conversation
niteria
marked this pull request as ready for review
November 17, 2026 18:32
niteria
force-pushed
the
j713/ext-edid
branch
from
November 17, 2026 19:31
8c463ae to
0c1d35c
Compare
The M4 external DCP builds its modes from the firmware's timing catalog and never read the sink's EDID: the connector had no EDID property, so compositors saw no monitor name, serial or physical size, and guessed the scale (Hyprland put a 1080p monitor at scale 2). Track the dcpav-service-epic the firmware announces on EP 0x28 for each sink, read its EDID with the inline/legacy reader of the generic path (new dcpavserv_read_edid()), and pass its SDR view (dcp_edid_sdr(), as native26 does) to drm_edid_connector_update() from get_modes. The modes stay the firmware catalog's: with the raw EDID, the probe helper would prune the catalog modes the sink lists as 4:2:0 only, as the connector does not allow 4:2:0. Keep the EDID for the sink's link and read it once per announcement of the AV service, which the firmware repeats after a relink or a resume: a failed read no longer takes the EDID from the connector, and a probe no longer costs a firmware call. As on the Neo, probe again when the service is announced, as get_modes may already have run without it, and, up to 5 times 500 ms apart, while the firmware answers without EDID bytes because it has not read the sink yet. Nothing is read from a stopped or failed session, and the service announced before a deep sleep goes with the stop. Tested on a J713 over USB-C HDMI adapters on both ports with a Samsung LS28AG700N (4K, 512-byte EDID, 256 bytes in its SDR view) and a Samsung S24F350: Hyprland shows each one's name, serial and size, picks scale 1 for 1080p, and applies a per-monitor rule (4K@30, scale 2) to the LS28AG700N after a boot with it attached and after a replug. The EDID is read once per announcement and stays published through the firmware's relink about 10 s into boot. Assisted-by: LLM Signed-off-by: Bartosz Nitka <niteria@gmail.com>
niteria
force-pushed
the
j713/ext-edid
branch
from
November 18, 2026 13:14
0c1d35c to
6b8638a
Compare
This was referenced Nov 19, 2026
Contributor
|
Works on a J773g (Mac mini M4) with #1192: HDMI to a G81SF, EDID published (256 bytes, the SDR view). KWin reads it; it warns only about the zeroed colorimetry, as intended. The EDID was published on every boot of the mini's new default kernel (this PR + #1192 + #2296), 5 boots, and it stays across suspend-to-idle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The M4 (T8132) external DCP builds its modes from the firmware's timing catalog and never read the sink's EDID, so the connector had no EDID property: compositors saw no monitor name, serial or physical size and guessed the scale (Hyprland put a 1080p monitor at scale 2).
This tracks the
dcpav-service-epicthe firmware announces on EP 0x28 for each sink, reads its EDID with the generic path's inline/legacy reader (newdcpavserv_read_edid()), and passes its SDR view (dcp_edid_sdr(), as native26 does) todrm_edid_connector_update()from get_modes. The modes stay the firmware catalog's; with the raw EDID, the probe helper would prune the catalog modes the sink lists as 4:2:0 only.The EDID is kept for the sink's link and read once per announcement of the AV service, which the firmware repeats after a relink or a resume: a failed read no longer blanks it, and probes no longer cost a firmware call. As on the Neo it probes again when the service is announced, and up to 5 times 500 ms apart while the firmware answers without EDID bytes because it has not read the sink yet. Nothing is read from a stopped or failed session, and the service announced before a deep sleep goes with the stop.
Tested on a J713 (MacBook Air M4) over USB-C HDMI adapters on both ports, with a Samsung LS28AG700N (4K, 512-byte EDID, 256 bytes in its SDR view) and a Samsung S24F350:
The first version was also tested with an HP HDMI-VGA adapter.
Host tests (
tools/asahi/run-host-tests.py, full run): 425/425 on both this branch and its base432f175816e9.Overlap checked against open PR heads: #1812 also edits
epic/dpavservep.c(the generic discovery wait), with no functional overlap; #1192 and #1940 touchiomfb_m4.c/t8132_ext_drm.cbut not EDID.🤖 Generated with Claude Code