Repository navigation
Conversation
|
Per |
04e1d87 to
396679f
Compare
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
RyanTheTide
left a comment
There was a problem hiding this comment.
Commit 7e92f49 is authored by Pavel Shago but carries only the submitter's Signed-off-by. It needs a Signed-off-by from its author as well (DCO, Documentation/process/submitting-patches.rst).
RyanTheTide
left a comment
There was a problem hiding this comment.
Besides the Signed-off-by from its author still needed on 7e92f49:
-
This no longer merges into integration/aurora. drivers/phy/apple/dptx.c conflicts with c0e42a1 ("phy: apple: dptx: Add the T6050 variant", from #940, merged as 328654f). Please rebase and keep both the T6050 and T8122 variants.
-
The description lists the exact head as not booted. After the rebase, please add the J773g result for that head (HDMI connector and modes, desktop, cold and warm boot). iomfb_m4.c, dcp.c and apple-dart.c are shared with J713, so please also add a J713 internal and external display check.
|
@techmore could you rebase this onto current Two other things are needed before we can merge:
We've changed how we handle hardware checks, so we no longer hold contributor PRs for them. Once the branch is rebased, signed off, green and approved, we'll merge it and run the shared-path J713 display check afterwards, with a revert ready. A note of the J773g boot on the rebased head (connector and modes, desktop) would still help if you have it. I'm reviewing the content now so it can go in as soon as the rebase lands. |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Content review against current integration/aurora, so this can merge as soon as it is rebased. It is otherwise well scoped. The new DCP, DRM and DART branches key on apple,t8132-dcp plus apple,connector-type = "HDMI-A", so other machines' display paths are unchanged, apart from items 2 and 3.
Required, besides the rebase (keep both the T6050 and T8122 variants in dptx.c) and Pavel's Signed-off-by on 7e92f49:
- Build break.
t8132_ext_drm.ccallsdcp_t8132_main_external()but includes neitherdcp.hnor any header declaring it, soCONFIG_DRM_APPLE_DCP_T8132=ydoesn't build. Add#include "dcp.h". - NULL
dcp_m4_pf. Iniomfb_m4_init(), J773g has no M4 profile.(!pf && !external)now lets a NULLpfthrough, sodcp_m4_pfis NULL at the first D590 callback or swap. It also starts admittingdcpexton M4 machines without a profile. Please keep the!pfrefusal and add a J773g profile without panel timing. - Runtime PM on every variant. In
dptx.c,devm_pm_runtime_enable()withoutpm_runtime_set_active()makes every DPTX PHY read as runtime-suspended. The T8112/T6020 fixed-HDMI paths never callphy_power_on(), so once appledrm evicts simpledrm, genpd can gate the PHY domain on those desktops. After the rebase this would also cover T6050. Please enable runtime PM forDPTX_PHY_T8122only. - Empty DRM device. In
apple_drv.c, whent8132_ext_drm_init()registers no output (for example on unqualified firmware), the driver still registers a DRM device and evicts simpledrm, which leaves a black screen. Please return-ENODEVin that case. reg-namesrequirement. Makingreg-namesrequired inapple,dptx-phy.yamlinvalidates the existingdptx_phynode int8122-peripherals.dtsi, which has noreg-namesand lists dptx before core. Please fix that node in the same commit, or drop the requirement.- AUX calibration. The T8122 activation reads the AUX calibration result back, then writes a fixed code. The
set32(..., 0)writes do nothing. Please compute the code from the readback, ast6050_impedance_calibration()does, and drop the no-op writes. - PMP-report commits. Nothing in the series uses the two PMP-report commits, and their
event-configwindow overlaps the DCP'sdisp-4range. Please split them into their own PR. - PR description. Please drop the reference to the private notes path and the provenance note, and update the outdated sign-off text.
Optional:
- Make a DPTX connect failure after adoption non-fatal. Currently probe fails after the session is pinned.
- Drop the unreachable M4 shutdown hunk in
dcp.c. - Drop the
&framebuffer0override, which now equals the default. - Say in the commit message why J773g doesn't use the j713 admission parameters.
- Note that with both dcpext outputs adopted, the HDMI output is silently skipped (
T8132_EXT_MAX).
Hardware checks won't hold the merge. We'll run the shared-path J713 display check after merge, with a revert ready.
bdd8b67 to
3638318
Compare
|
Rebased onto current
Optional items: a DPTX connect failure after adoption is now a warning; the unreachable M4 hunk in The PHY commit's author is Niklas Sheth. It carries his Signed-off-by and a Checked before pushing, at every commit, with the J773g config ( This head has not been run on the J773g. Item 6 changes register writes there, so I will test it and add the connector, modes and desktop result here. |
|
Hardware test, Mac mini M4 (J773g), 2026-11-14: at this PR's exact head Kernel: The display driver did not take over the HDMI output. The kernel log shows: The screen stayed on the firmware framebuffer ( We are finding the cause and will push a fix together with hardware evidence. Until then I am converting this PR to a draft so it is not merged in this state. |
|
Update to my earlier FAIL note: that result remains valid for the unmodified #1192 DTB. The successful runs below used a source-built DTB containing one additional J773g DTS completion commit; they therefore supersede the earlier result only for the completed DTS. I have fast-forwarded one commit,
The four commits already in #1192 are unchanged, including Niklas Sheth's authorship and trailers on the T8122 DPTX PHY commit. Hardware resultFive consecutive J773g soak boots (S1–S5) reached the graphical login display. In every run:
S2 also completed an explicit 3840x2160@30 modeset. A further C1 boot passed on the rebased combined tips. Camera frames show the login display for S1–S5 and C1. Artifact provenance: S1–S5 used kernel Image H1 is not included in the pass count: SDDM appeared, but SSH did not answer within 240 seconds and a later restart stuck in Stage 1. Validation limitsThe full Not covered: cold entry, 4K60, HDMI audio, hotplug, Wi-Fi association, Bluetooth traffic, a front USB device, J713, or other boards. |
|
Second J773g PASS for 3638318 + 7004918 (Mac mini M4; kernel = techmore hwtest 787d70b; Stage 2 = aura b8461a80 + 083dbc3f + 79fcfc00 + 7fdadb3e; stock Aurora U-Boot; Stage 1 1.0.0b8, stub 26.6.2). 3/3 boots: /dev/dri shows card1-HDMI-A-1 and renderD128. An Omarchy/Hyprland desktop runs GPU-accelerated on it; renderer screenshot to follow. Note: a Stage 2 that lights HDMI itself (the aura boot-hdmi v7 series) leaves SID23 tables outside the ADT pt-region: |
|
Renderer follow-up for the J773g PASS above, under the Omarchy/Hyprland Wayland session (eglinfo/glxinfo): That's hardware rendering on the G16G, not llvmpipe. |
|
Tested #1192 (with aura #199 + #258) on the owner's Mac mini J773g (26.6.2 stub, HDMI to a 4K240 monitor whose sink offers 1080p), 2026-11-19, with Linux #1192, as aura-try trials. The Stage 2 was techmore's boot-HDMI series (fdf65101, the one that trains HDMI on this unit) + #113 + this stack, then two fixes. The full stack is public as aurora-silicon/aura
🤖 Generated with Claude Code |
|
Follow-up from the same Mac mini J773g, 2026-11-19 05:26: with this PR and the aura stack from my earlier comment, HDMI KMS works. KWin trips on one thing, and frames get dropped.
🤖 Generated with Claude Code |
|
J773g results with this PR, from the M4 mini drivers lane (2026-11-19). This is now the mini's default boot: kernel 7.3.0-ARCH-m4drv8, which is this PR + #2166 + #2296 on the M4 mini GPU stack, with the HDMI DT in the configured boot.bin.
|
7004918 to
d480ca7
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
d480ca7 to
b8880d5
Compare
|
Which do you prefer: accept it here as on the J713, or I first add One of the two fixes moves the J773g's display-subsystem node to the root, which reverses 76b6d84 for this board only. It has run on my 27.2 unit but not on a 26.6.2 setup. If the node should stay under |
A T8132 main DCP wired to fixed HDMI uses six firmware segments and shares the retained SID 0/SID 16 frontend contract with the external display path. Qualify that layout from the available main DCP and its connector role. Validate its physical framebuffer separately from inherited mappings and preserve both frontend streams without a board-name gate. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
Some T8132 desktops route the main DCP through a fixed DPTX-to-HDMI path instead of an internal panel. Use the connector-type property as that role contract, prepare the PHY and converter rails, adopt the retained firmware session, and register it through the external-output KMS path. Accept the retained physical framebuffer without manual bind controls or machine-name checks. Use a J773g M4 profile without panel timing and continue to refuse machines without a profile. J773g does not use the J713 panel admission parameters because the external path skips apple_pmp_j713_display_prepare() and has no internal panel timing or panel power admission. Keep an empty external device from replacing simpledrm, and retain an adopted session when its initial HDMI DPTX connect fails. The external KMS layer still caps the device at two outputs, so two adopted dcpext outputs leave the fixed HDMI output unregistered. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
T8122 (as used on T8132) needs its own cold activation: the T8112 core power steps, moved enable/clear bits (0x2218, 0x2234), a different 0x2230 setting, no 0x4008/0x420c/0x4404/0x4408/0x4600 steps, and an AUX impedance calibration whose result is copied into 0x4228. At link-rate change it clears 0x222c bit 1 instead of 0x2220 bit 7, takes the T6020 settings for 0x20b0, the first 0x20b4 write and 0x20b8 bit 16, then clears 0x20b4 bit 1 and skips the 0x20b8 bit 21 clear. For T8122 only, enable runtime PM before creating the PHY so the generic PHY core propagates runtime-PM references to the provider. The T8112, T6020 and T6050 paths are unchanged. Link: GravityLinux/linux@877c574 Assisted-By: OpenAI Codex (GPT-5.6 Sol) Signed-off-by: Niklas Sheth <hi@niklassheth.com> [Sean: extracted the T8122 hunk; rebased over T6050; runtime PM for T8122 only; calibration code from the readback] Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
The T8132 display subsystem node has carried dma-noncoherent since it was
added, and the binding does not list it. dtbs_check did not notice: the
node is disabled in the shared tree and enabled by the boot loader on the
boards with a panel. A board that enables it in its device tree gets
display-subsystem: Unevaluated properties are not allowed
('dma-noncoherent' was unexpected)
Allow the property.
Assisted-by: LLM
Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
The Mac mini routes its main DCP through the T8122 DPTX PHY and an HDMI converter controlled by two SMC GPIOs. Describe that fixed path and enable the retained DCP, mailbox, and display DART nodes. Do not attach the DCP or mailbox to DISP_CPU: iBoot leaves that domain in auto mode and direct PMGR writes fault on this machine. The display subsystem node has no registers and is enabled here, so it is described at the root rather than under the simple-bus (dtbs_check: "soc: display-subsystem: 'ranges' is a required property"); the disp0 alias follows its label. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
With only the HDMI path described, the Mac mini still has no display:
- The DPTX PHY sits on ps_dptx_phy, which the J713 PMGR policy (applied
to every M4 board that does not state the domain) keeps from Linux.
phy-apple-dptx and the DCP behind it wait for it until the deferred
probe timeout (-110). State the domain for this board, as it already
does for the ATC2 and ATC3 domains.
- The DCP's PIODMA child owns iommu-addresses entries in
/reserved-memory, so the DCP node needs #address-cells and
#size-cells; the display DART's admission otherwise warns that both
are missing.
- The loader and the display DART look the PIODMA stream up by the
disp0_piodma alias, as on T8122; add it.
- genpd powers ps_dptx_phy off over a suspend-to-idle and the PHY keeps
no state, so the modeset replayed on resume fails ("DPTXPort: firmware
reports link fault 22 on target 0:4", then -67). Mark the domain
apple,always-on. Found and tested by Diljit Singh on a J773g (macOS
26.6.2): the display is restored on 3 of 3 resumes.
Assisted-by: LLM
Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
b8880d5 to
db7d34d
Compare
Summary
HDMI output on the M4 Mac mini (J773g). On this machine the main DCP drives the HDMI port through the T8122 DPTX PHY and a DP-to-HDMI converter, and iBoot hands the display over already running.
Six commits:
iommu: apple-dart: adopt the T8132 main external display handoff.drm: apple: dcp: adopt a T8132 main DCP whose output is an external connector, with a J773g profile that has no panel timing.phy: apple: dptx: add the T8122 PHY next to the T6050 variant. Runtime PM is enabled for T8122 only.dt-bindings: display: apple,display-subsystem: allowdma-noncoherent, which the shared T8132 node has always carried.arm64: dts: apple: t8132-j773g: enable the DPTX PHY, the DCP and the HDMI connector; on this board the display-subsystem node is described at the root.arm64: dts: apple: t8132-j773g: complete the HDMI display description (theps_dptx_phydomain, kept on; the DCP's cells; thedisp0_piodmaalias).The PHY commit is Niklas Sheth's: it carries his Signed-off-by and a
Link:to his commit, then a note of the changes made here. The earlier PHY commit by another author (7e92f4929531), whose sign-off was asked for in review, is no longer in the series.The DCP, DRM and DART changes key on
apple,t8132-dcpwithapple,connector-type = "HDMI-A".Testing
Every commit builds with the J773g config (
CONFIG_DRM_APPLE_DCP_T8132=y) andW=1fordrivers/phy/apple/dptx.o,drivers/iommu/apple-dart.o,drivers/gpu/drm/apple/and the t8132 and t8122 device trees.dptx.oalso builds with arm64 defconfig plusARCH_APPLEandPHY_APPLE_DPTX. The tip buildsImage, device trees and modules.dt_binding_checkpasses forapple,dptx-phy.yaml. Theapple-dcphost tests pass in CI.CHECK_DTBSwas not run: dt-validate crashes onapple,tunablein this tree.Hardware: DjDeveloperr runs this PR with #2166 and #2296 on top as the default boot of a J773g on a 26.6.2 stub (his comments of 2026-11-19): KWin drives HDMI at 1920x1080@120, and with the
ps_dptx_phychange the display is restored on 3 of 3 resumes. Not booted by me at this head: my J773g is on a 27.2 stub, whose DCP firmware needs further changes that are not in this PR. J713 and the other DPTX PHY users were not tested.Dependencies
None.
Suspend-to-idle (2026-11-19)
ps_dptx_phyis nowapple,always-onon the J773g, folded into "arm64: dts: apple: t8132-j773g: complete the HDMI display description" as DjDeveloperr asked. genpd powered the domain off over a sleep, the PHY keeps no state, and the modeset replayed on resume failed (DPTXPort: firmware reports link fault 22 on target 0:4, then-67).dtbs_checkwas not run.Related, on top of this PR: #2296 (cursor plane; also the
frame not shown: -16drops) and #2166 (EDID).dt-checks (2026-11-19)
The
dt-checksjob reported three new warnings fort8132-j773g.dtbon the previous head. Two are fixed; one is not, so the job will still fail on this push.display-subsystem: Unevaluated properties … ('dma-noncoherent' was unexpected)t8132-dcp.dtsinode has always carried the property and the binding never listed it. It shows now because this board is the first to enable the node in its device tree.dma-noncoherent: trueinapple,display-subsystem.yaml, as its own commit.soc (simple-bus): display-subsystem: 'ranges' is a required propertyregcannot be a child of a simple-bus once enabled.disp0alias follows the label. The shared tree is not changed.aliases: 'disp0_piodma' does not match any of the regexesaliases.yamlforbids the underscore.dt_set_j713_display_maps(), aurasrc/kboot.c:7859,:7916) resolves onlydisp0_piodma, so renaming the alias here breaks the handoff, and a second alias does not remove the warning.t8132-j713.dtbhas the same warning in the base. Removing it needs the loader to acceptdisp0-piodmaon that path first, then the kernel lookups, then this dts.The node move reverses 76b6d84 for the J773g only. Kernel and loader find the node by the
disp0alias and by compatible, never by path. The platform device becomesdisplay-subsystem(wassoc:display-subsystem), which changes sysfs and/dev/dri/by-path.Booted once on a J773g (27.2 stub, 1080p) with the same device-tree content on our 27.2 display test tree, not this PR's head or its DTB:
disp0=/display-subsystem, SID0/SID16 admitted,card1-HDMI-A-1connected, kernel display lines identical to the/socrun apart from the device name. Nobody watched the monitor. DjDeveloperr's 26.6.2 setup (this PR + #2166 + #2296, G16) has not run the move.Validated with dtschema 2025.2 (
dt-validateon the built DTBs): the J773g DTB has one new line against the base, the alias warning. The binding change was checked on the Apple DTBs with an enabled display-subsystem node, built at this head: none gains a line.scripts/dtc/apple-dt-check.shitself andmake dt_binding_checkwere not run; onlydt-doc-validateon the binding. checkpatch--strictis clean on the three new or amended commits.