Repository navigation
thermal: apple-pmp: fix J773g thermal zone registration - #1865
Conversation
The T8132 thermal policy currently describes J713's four P-core and six E-core policies unconditionally. J773g exposes the same cluster sizes with different logical CPU numbers: P cores 0,3,4,5 and E cores 1,2,6,7,8,9. The exact related_cpus check therefore rejects J773g with -EINVAL before registering its thermal zone. Select the J773g masks from the machine compatible while retaining the existing J713 masks for other T8132 systems. The live J773g cpufreq policies report related_cpus as "0 3 4 5" and "1 2 6 7 8 9". Before the fix, setup returned -EINVAL, no thermal zone registered, and the policies remained at 1.800/1.860 GHz. With the fix, apple-pmp-die and power telemetry registered, P/E reached 4.104/2.892 GHz, pinned 7-Zip 26.04 measured 8,460 MIPS, and a five-minute all-core load peaked at 79.25 degrees C without kernel errors. Fixes: 7953e28 ("soc: apple: t8132: take the PMP bridge and thermal path on the qualified boards") Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
d86050a to
9c71c29
Compare
|
Hardware test, Mac mini M4 (J773g), 2026-11-14: PASS at this PR's head Kernel:
Observed behaviour under 60 s of load (one busy loop pinned to each of the 10 CPUs, sampled every 5 s):
At probe the driver logged 10 Not covered: load longer than 60 s, and GPU-only load against the |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Reviewed. The masks match the J773g's cpufreq policies (P 0,3-5; E 1-2,6-9). The CPU arguments to apple_pmp_add_cluster() (0 for P, 1 for E) still name a CPU of the right cluster there. Every other T8132 machine keeps J713's masks, and apart from that only the log text changes. The 5-minute all-core run peaked well below the 106 °C cooling trip.
host-tests is green on this head. Base drift doesn't touch apple-pmp-thermal.c. Approving and merging.
2015108
into
aurora-silicon:integration/aurora
Summary
The T8132 PMP thermal policy uses J713's logical CPU masks for every T8132 machine. J773g has the same four-P/six-E cluster sizes with different logical numbering, so the exact
related_cpuscheck inapple_pmp_add_cluster()returns-EINVALand no thermal zone is registered. Without the zone, cpufreq keeps its bootstrap frequency cap.This commit selects P CPUs
0,3,4,5and E CPUs1,2,6,7,8,9when the machine isapple,j773g. Other T8132 machines keep the existing masks.The masks are the live J773g cpufreq policies: policy0
related_cpusis0 3 4 5and policy1 is1 2 6 7 8 9.Fixes:names 7953e28, which enabled this thermal path on J773g.Testing
Hardware: M4 Mac mini (J773g), macOS firmware 26.6.2.
apple-pmp-dieFive minutes at all-core load: both clusters held 4.104/2.892 GHz, the die temperature rose from 52.5 °C to a sampled peak of 79.25 °C, and the journal had no thermal, GPU, watchdog, panic or oops messages.
Tested tree:
integration/auroraat 6882c13 plus our J773g branches and #1718, with a patch byte-identical to this commit. That is a combined tree, so the table is an end-to-end result, not a one-variable benchmark. What this patch itself changes was observed directly: the-EINVALis gone and the zone registers.Not tested: this exact head on current
integration/aurorahas not been booted. J713 was not tested; its masks are unchanged.Dependencies
None. One commit,
drivers/thermal/apple-pmp-thermal.conly. Independent of #1191 and #1718.