Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@techmore the code looks good. The commit still has no Signed-off-by. Please add it (git commit --amend -s) and force-push, and we can merge. |
9b49d76 to
4cf3ab6
Compare
J773g loads a distinct normalized 25G83 image after iBoot fills a header word at 0x224 and the eight-byte DILS payload at 0x5c917. Add those per-boot regions and the measured digest so firmware admission recognizes that image. The same identity was boot-tested on a J773g with 25G83: GPU firmware started and accelerated rendering worked. Cover the new table entry with the existing measured-image lookup tests. Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
4cf3ab6 to
5fbbff2
Compare
|
Hardware test, Mac mini M4 (J773g), 2026-11-14: PASS at this PR's head Kernel:
Not covered: Vulkan (no Vulkan tools on the test system) and GPU load longer than one 45 s glmark2 run. |
|
The production boot stub pins at macOS 27.2 (26B123), so please retarget this to 27.2. 25G83 is the 26.6.2 stub's GPU image; please identify the J773g G16 image loaded by the 27.2 stub instead. |
|
Hardware test, second Mac mini M4 (J773g, 24 GB), 2026-11-19: this PR's digest does not match this machine. Setup: macOS 26.6.2 stub (25G83 GPU image) and aura 1.0.0b13 with the boot-HDMI Stage 2. Kernel is the linux-aurora 7.3.0-40 pin (9125b31) + #1898 + #1191 at
#2232 zeroes every record value instead, keeping the tags and lengths and the rest of TEXT exact. With it, this machine admits the image, reaches READY and KWin composites on the GPU (details in #2232). Could you check whether your J773g also matches #2232's digest 🤖 Generated with Claude Code |
|
Follow-up: I compared the loaded TEXT with Apple's
#2232 now zeroes exactly those ranges. Its digest 🤖 Generated with Claude Code |
|
Checked on our J773g (16 GB, board-id 0x2a). 25G83 (26.6.2 stub): matches #2232. Three loaded-TEXT dumps from three boots, with #2232's 45 ranges zeroed, all hash to 26B123 (27.2 stub), in case it is useful for a second entry: TEXT is 0x64000, same structure at shifted offsets (parameter block at 0x60a1b, tables at 0x60c4c and 0x60f9c). The same rule gives Closing this in favour of #2232. |
Summary
Evidence
On J773g with 25G83, the loaded image has a zeroed per-boot word at
0x224, an iBoot-filled DILS payload at0x5c917, and normalized SHA-2569154c7f84bce32151e8a97417d6a207a9eaf0354b4b8d6f02af5299540d3e85a. A previously boot-tested J773g kernel carrying the same identity initialized the GPU firmware and provided accelerated rendering.Checks
scripts/checkpatch.pl --strict --no-signoff: cleanSigned-off-by from the author to follow.