Repository navigation
drm/asahi: g16: Admit the 25G83 B0 image with iBoot's ranges zeroed - #2232
Open
DjDeveloperr wants to merge 1 commit into
Open
DjDeveloperr wants to merge 1 commit into
DjDeveloperr wants to merge 1 commit into
Conversation
This was referenced Nov 19, 2026
iBoot writes into the 25G83 GPU TEXT it loads, and part of what it writes depends on the machine. Compared with build b000 (G16G B0) of armfw_g16g.im4p in 25G83, a Mac mini (J773g, 24 GB) loads a TEXT that differs in: - the header word at 0x224, which changes from boot to boot, and the DATA address at 0x23c; - the value of each of the 39 boot parameter records the header at 0x22c places from 0x5c8df to 0x5cb10 (a tag, a 32-bit length and the value): carveout addresses just below the top of DRAM, which follow the memory size, a per-boot slide and the entropy; - the entry count and body of the two 0x350-byte tunable tables at 0x5cb10 and 0x5ce60, which the shipped image leaves empty. The T8132 entries hash a loaded image with only the entropy or one record zeroed, so each fits the machines it was measured on, and G16 refuses this Mac mini's image with EINVAL. Add an entry that zeroes all of those ranges. Its digest is that of the shipped build b000 TEXT with the same ranges zeroed, and two boots of the Mac mini give the same digest, so it pins the 25G83 B0 code as Apple ships it rather than one machine's memory map, slide or tunables. Every other byte, including the record tags and lengths and the table headers, is compared as loaded. The existing entries are unchanged. A test checks the ranges' layout and that the digest selects the entry. Signed-off-by: Diljit Singh <hey@djdev.me>
DjDeveloperr
force-pushed
the
djdev/j773g-g16-boot-parameters
branch
from
November 19, 2026 06:56
1e9eb0c to
6dfa2ac
Compare
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
G16 refuses the 25G83 GPU firmware on a 24 GB Mac mini (J773g) with
loaded GFX TEXT identity mismatch: EINVAL.I compared the TEXT loaded on two boots with Apple's file: build
b000(G16G B0) ofarmfw_g16g.im4p, taken from the macOS 26.6.2 stub's Preboot (Restore/Firmware/agx/). iBoot writes into these ranges:SLIDslide (per boot), GKTS/ECAP entropy, SoC id/revision, …01 03 2a/03 03 2a)Every other byte matches Apple's file. This adds a T8132 entry that zeroes exactly those ranges. Its digest
b9ea7e6b2aca…equals the shipped b000 TEXT with the same ranges zeroed, so the entry pins Apple's 25G83 B0 code rather than one machine's memory map, slide or tunables. Record tags/lengths, table headers and the rest of TEXT are still compared exactly. Existing entries are unchanged.#1718's J773g entry zeroes only 0x224 and the slide, so it fits one machine: on this mini that normalization gives
9b100498…, not9154c7f8….Test (Mac mini M4 J773g, 24 GB, macOS 26.6.2 stub, aura 1.0.0b13 + boot-HDMI Stage 2)
Kernel: the linux-aurora 7.3.0-40 pin (9125b31) + #1898 + #1191 (with #1718) + this commit + the T8132 cluster fix for apple-pmp-thermal. Distribution config, release
7.3.0-ARCH-m4gpu1, Arch Linux ARM, Mesa 26.3.0-devel d4ad4a4dce, KWin 6.8.2.b9ea7e6b….GPU firmware build: Apple GFX 25G83 (build b000, iBoot-filled ranges zeroed),M4: firmware identity accepted,firmware at READY,[drm] Initialized aurora 1.0.0 … on minor 1.Apple M4 (G16G B0)(GL 4.6, ES 3.2).glmark2-es2-drm --off-screen(build/texture/shading/refract, 10 s each, 1920x1080): rc 0, score 453. No GPU errors, faults or timeouts in the kernel log.d0d2a026…) also admitted the image on this machine. It was replaced because the tunable tables could differ between chips.The GPU still needs #1191's J773g PMP/DVFS commits. This PR replaces only #1718's firmware-identity part.
🤖 Generated with Claude Code