Repository navigation
Conversation
The T8152 (M6) PMGR blocks are compatible with the T8103 ones. The J873 device tree already uses this compatible; document it. Signed-off-by: LiamRay11 <228416644+LiamRay11@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The T8152 (M6) PMGR power state controls are compatible with the T8103 ones. The J873 device tree already uses this compatible; document it. Signed-off-by: LiamRay11 <228416644+LiamRay11@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The I2C controllers of T8152 (M6) are compatible with the T8103 ones. Signed-off-by: LiamRay11 <228416644+LiamRay11@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The T8152 (M6) watchdog is compatible with the T8103 one. Signed-off-by: LiamRay11 <228416644+LiamRay11@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The T8152 (M6) FPWM, which drives the keyboard backlight of the J804 MacBook Pro, is compatible with the S5L one. Signed-off-by: LiamRay11 <228416644+LiamRay11@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reading every pin of the T8152 GPIO block to fill a register cache at probe takes an SError on the J804 MacBook Pro: pins 78 and 208 fault on an AP read. The T8140 profile accesses the block uncached and honours gpio-reserved-ranges, so a board that has to keep the CPU off such pins can use "apple,t8152-pinctrl", "apple,t8140-pinctrl", as T6050 does with its T8132 fallback. The existing T8103 fallback stays valid for boards that do not need it. Signed-off-by: LiamRay11 <228416644+LiamRay11@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
As on T8140, the OS cannot request core power-down on T8152 (M6) and WFI is the only idle state. Allow "apple,t8152-cpuidle" with the T8140 compatible as its fallback, which the driver already matches. Signed-off-by: LiamRay11 <228416644+LiamRay11@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Turn the disabled J804 inventory into a board description for a RAM
boot from the loader, on top of the shared T8152 description:
- the twelve CPUs (the loader removes those it has not started),
with the first two performance states of each cluster, which the
cpufreq driver may use without a thermal policy, as on J873
- the AIC and the timer, the boot framebuffer and CPU idle
- the SMC with its mailbox, the pcIO output that resets the
trackpad's touch controller, and the hardware monitor: fan, power,
voltage and current keys, with temperatures discovered. The fan
is monitored only; its speed stays under firmware control
- the watchdog, the GPIO controller with the pins that fault on an
AP read reserved, the I2C controllers of the jack codec and the
speaker amplifiers, and the keyboard backlight PWM
- the boot NOR and the PMGR block from t8152-j873-qspi.dtsi, shared
with J873, plus the SIO and I2C power states
Everything else stays described and disabled; the storage, display,
input, wireless and GPU nodes follow with their drivers. The values
come from the J804 ADT.
Tested on a MacBook Pro (M6, J804) with an equivalent standalone device
tree on an earlier base (integration/aurora f5fa539): all twelve CPUs
come up, the watchdog restarts the machine, the SMC hardware monitor
reports about 170 inputs including the fan, the keyboard backlight
lights, and the NVRAM partition of the boot NOR reads. This tree,
rewritten onto the shared T8152 labels, has not been booted.
Signed-off-by: LiamRay11 <228416644+LiamRay11@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sithglan
reviewed
Nov 17, 2026
sithglan
left a comment
Contributor
There was a problem hiding this comment.
Test report, 2026-11-17: Apple Mac mini M6 (J873g/T8152, board 0x24). PR revision tested: a96fb0778c158b79a93a2efea123b182143a626b.
Host validation used the combined #2105–2108/#2110–2112 series (54742c617db4 on 677be395b9d2) with Clang 22. All changed driver objects built with W=1 and no new warnings; two pre-existing DART unused-helper warnings were unchanged.
All 137 Apple DTBs built at both base and combined head, with zero new warning lines and eight removed. All ten changed bindings passed dt_binding_check. This validates the shared binding changes and the J804 DT build. The test machine is J873g, so J804 board behavior was not hardware-tested.
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns the disabled J804 inventory (
t8152-j804.dts, 12 lines ont8152.dtsi) into a board description for a RAM boot from the loader (aurora,minimal-boot, as J873g). It builds on the shared T8152 description and its canonical labels, and adds the bindings the board needs. Storage, display, input, wireless, GPU, audio and media nodes follow with their drivers.Commits
apple,t8152-pmgrandapple,t8152-pmgr-pwrstate. These are already used by the J873 DT, so this also removes base warnings.apple,t8152-i2c,apple,t8152-wdt,apple,t8152-fpwmapple,t8152-pinctrlwith anapple,t8140-pinctrlfallback. T8140 is the uncached profile that honoursgpio-reserved-ranges, following the existing T6050 -> T8132 pattern. With the T8103 profile, J804 takes an SError at probe reading pins 78/208. J873 is unchanged.apple,t8152-cpuidlewith anapple,t8140-cpuidlefallback, which the driver already matches.arm64: dts: apple: t8152-j804:apple,smc-pcio-gpiooutput for the trackpad AFE reset, and hwmon with fan/power/voltage/current keys. The fan is monitored only: there is noapple,fan-manual-control, so its speed stays under firmware control as on the other T8152 boardsLED_FUNCTION_KBD_BACKLIGHT,LED_COLOR_ID_WHITE)t8152-j873-qspi.dtsi, which J804 shares with J873g, plus SIO/I2C power states. Renaming it to a board-neutral name would touch J873g, so it is left for a separate change.hwmon-common.dtsi/hwmon-laptop.dtsi: those hardcode temperature keys, while J804 usesapple,discover-temperatures, and its fan mode key is the lower-caseF0mdTesting
On hardware: MacBook Pro 14-inch (M6, J804), 2026-11-16, tested by LiamRay11.
bf423bf0ewith all nine J804 linux PRs merged (t8152-mailboxes, dart-gen3, dt-board, centauri, g18-fast-retire, cfg80211-stale-scan, smc, cs42l84-jack, and an NVMe PR that is not sent yet), plus retest-only device-tree changes that are not part of these PRs: SSD nodes (ANS mailbox, SART, NVMe), PCIe port 0 with the N1 Wi-Fi, the USB0 gadget console, and aread-onlyNVRAM partition. Those nodes were needed to reach the root filesystem and SSH.systemctl rebootfrom this kernel (watchdog restart) returned to the installed system.Results for this PR (this board file plus the retest-only nodes above):
apple_idle), the watchdog (/dev/watchdog0; the restart above went through it), the NOR partitions (aura_stage2.log,adt,nvram),kbd_backlight,i2c-0/i2c-1and pinctrl with the reserved ranges all probe and work.nvrampartition writable, as upstream'st8152-j873-qspi.dtsi(shared with J873g) has it for asahi-nvram and asahi-bless. The retest tree addedread-onlyto it (mtd flags 0x800), so writes to it were not exercised.t8152-j804.dtbitself has no CHECK_DTBS warning.Known limitation: cpufreq logs
invalid apple,fast-die-effort (-2): CPUs 1-6 stay limited to 972000 kHz. T8152's cpufreq expects a fast-die limit, and this tree does not provideapple,fast-die-effort(-2 is -ENOENT; the PMP report it would point at is not described yet), so the cluster keeps the driver's fallback limit. It is left for the follow-up with the full OPP tables and the thermal policy (see Deviations).Checks on this base:
scripts/dtc/apple-dt-check.sh(basebf423bf0e, head = this series together with j804/dart-gen3, j804/t8152-mailboxes and the J804 NVMe change): 137 Apple DTBs built at both, 0 new CHECK_DTBS warnings (8 removed: the J873gapple,t8152-pmgr/-pmgr-pwrstateones), anddt_binding_checkpasses for every changed binding.integration/aurora has since moved to
677be395b; this branch still merges into it without conflicts.Deviations from the bring-up tree
apple,tlbi-aperturefromj804/dart-gen3. The retest tree described USB0 as a gadget console with upstream's DART node model and it worked; the USB nodes come with their own PR.apple,t8152-spmi,apple,woodcote-pmic) and are follow-ups.Hardware values
Addresses, IRQs, power-state offsets, the pcIO template and the GPIO reserved ranges are hardware description from the J804 ADT, in the same style as the existing T8152 files. There are no per-unit values: memory, CPU release addresses, the framebuffer, MAC and BD addresses are filled by the loader.
Dependencies
None for the tree. The SMC's input, power and pcIO cells only register with
j804/smc; without it the SMC is telemetry-only, as on J873. Later J804 PRs build on this one.🤖 Generated with Claude Code