Skip to content

aurora-sep: retry Ctrl-C in the survey stop test - #2160

Merged
RyanTheTide merged 1 commit into
aurora-silicon:integration/aurorafrom
joshuaswarren:w7J/mv443-ctrlc-retest-v2
Nov 17, 2026
Merged

RyanTheTide merged 1 commit into
aurora-silicon:integration/aurorafrom
joshuaswarren:w7J/mv443-ctrlc-retest-v2

Conversation

@joshuaswarren

Copy link
Copy Markdown
Contributor

[Joshua's agent] aurora-sep: retry Ctrl-C in the survey stop test

The M3 survey-stop test failed in CI with AssertionError: 0 != 130 (empty
stderr): the check that the survey dies on Ctrl-C saw exit 0 instead. The
survey sometimes runs to the end after one SIGINT; cause not established, most
likely the signal arriving while bash defers it (the INT trap is installed
before any load starts and is never reset, so it is not a missing handler).
The test now retries the SIGINT up to 4 times with a short wait each — what a
user does when the first Ctrl-C seems lost — then falls back to the long wait.
Same assertions as before: exit 130, the "interrupted" line on stderr, no
leftover output. The retry is a stated workaround, not a fix for the cause.

Honest state: host-side test change only (tools/aurora-sep/tests/test_m3_max.py,
+11/-2), no kernel code touched. Ran green on the submitter's host with the
pick applied (test_ctrl_c_stops_the_load: 1 passed, 67 deselected). Old CI on
the omacom PR was all green; no maintainer review there. This move supersedes
omacom/linux-aurora#443 (same commit, rebased onto today's
aurora-silicon/linux integration/aurora). Never booted as part of a kernel
build — it is a host test, run with pytest on Linux.

(cherry picked from commit 796e02859d18ce3ac6c787d97fdbff221dc2e76c)
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-17T16:18:33.149085Z
We couldn’t complete this review. Comment @codex review to try again.
eed0c6e PR opened
🔒 Security Review ❌ Failed 2026-11-17T16:18:41.385934Z
We couldn’t complete this review. Comment @codex security review to try again.
eed0c6e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@joshuaswarren

Copy link
Copy Markdown
Contributor Author

GREEN on eed0c6e
Model: zai/glm-5.3-flash

Two-round review. Round 1 at 796e02859d: content GO (the +11/-2 survey-stop test change is byte-identical to omacom #443's diff, author kept, honest-state lines complete), one finding: parent a7dd26e is behind current main. Round 2 re-check at eed0c6e: rebased onto current aurora main dcce0e7 (base rule satisfied), test file bytes identical (sha256 db47c5ad917e), cherry-pick trailer now present (cherry picked from 796e02859d18), author preserved, and the test ran green on the submitter's host (1 passed, 67 deselected).

Text confirmed: cause-not-established framing with the INT trap / bash-signal-deferral as the most-likely hypothesis, retry clearly stated as a workaround rather than a fix, same assertions as before (exit 130, "interrupted" line on stderr, no leftover output). Supersedes omacom/linux-aurora#443. Host-side test only, never part of a kernel build - READY (non-draft) state is appropriate.

GREEN on eed0c6e.

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

@RyanTheTide
RyanTheTide merged commit 9bb8bc5 into aurora-silicon:integration/aurora Nov 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants