Repository navigation
aurora-sep: send Ctrl-C again in the survey stop test (flaky 0 != 130) - #443
Closed
joshuaswarren wants to merge 1 commit into
Closed
joshuaswarren wants to merge 1 commit into
joshuaswarren wants to merge 1 commit into
Conversation
test_ctrl_c_stops_the_load sent one SIGINT and then waited 30 s. Under load bash sometimes drops that signal. The survey then runs to the end and exits 0, and the test fails with "0 != 130" (CI run 42771530679 on PR 191, passed on re-run of the same head). Send SIGINT again every 2 s, up to 4 times, like a user who presses Ctrl-C again. The 130 exit code and stderr checks stay as they were. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
joshuaswarren
force-pushed
the
w7J/survey-ctrl-c-test-flake
branch
from
November 11, 2026 04:00
257c2c1 to
a3d44fa
Compare
Author
Author
|
[Joshua's agent] Closing in favor of aurora-silicon/linux#2160, which carries the same fix rebased onto current aurora-silicon main (test bytes identical, authors kept). One PR per change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Joshua's agent] Fixes the flaky test that made two checks fail on #191 (run 42771530679, job 129680296443).
Problem
test_ctrl_c_stops_the_loadfailed in CI withAssertionError: 0 != 130 :(stderr empty). The same head passed on re-run (run 42777741719). The checks that still show as failed on #191 are the entries of the first run.Cause
The test sends one SIGINT to the survey and waits. Under load that signal is sometimes lost. The survey keeps running, finishes all phases, and exits 0.
I added a check before the kill to tell a lost signal from a late kill. In 3 failing runs the survey was still alive just before the kill (
p.poll()wasNone, 32 loads running). It then ran 27 to 30 s more and exited 0. So the signal was lost. It was not sent too late.Change
Send SIGINT again every 2 s, up to 4 times, like a user who presses Ctrl-C again. The exit code 130, the stderr check and the cleanup checks stay as they were. Only
tools/aurora-sep/tests/test_m3_max.pychanges (+11 -2).Measured
Load: 12 test runs at once plus 24 busy loops on a 16-core Linux box. This is heavier than the CI runner on purpose. The 200-run batch used a copy of the test that only adds the
p.poll()check before the kill.The whole
test_m3_maxmodule also passes with this change (68 tests, 1 skipped).Not covered
install-aurora-sep.sh. @chriskearney, you own the survey, so you may want a fix there.line 2: unexpected EOF while looking for matching ')'and the exit code was 2. It is a different problem and this PR does not touch it.bash -ccalls in other tests can time out. Not changed.