Repository navigation
hk: M5 pNext walks and a stray test file - #95
Merged
Merged
Conversation
src/asahi/compiler/test-agx3-m5-instructions.c is an early copy of compiler/test/test-agx3-m5-instructions.c. Meson only builds the one under test/ (src/asahi/lib/meson.build), and nothing else refers to the stray copy.
hk_g17p_compression_eligible() walks a VkImageCreateInfo chain by copying each sType and then copying pNext straight into the cursor. Its comment explains why: through a copied VkBaseInStructure, GCC 16's points-to analysis loses the chain and drops the stores of a stack-built chain. The M5 colour, G17S list and M5 depth eligibility checks still copied a whole VkBaseInStructure per link. Read their chains the same way. hk_g17p_compression_test: 4069 checks pass.
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small cleanups from maralcbr's review of omacom#19:
src/asahi/compiler/test-agx3-m5-instructions.cis an early 5 KB copy. Meson only buildscompiler/test/test-agx3-m5-instructions.c(src/asahi/lib/meson.build), and nothing else refers to the stray file.hk_g17p_compression_eligible()copies eachsTypeand then copiespNextstraight into the cursor. Its comment explains why: through a copiedVkBaseInStructure, GCC 16's points-to analysis loses the chain and drops the stores of a stack-built chain. The M5 colour, G17S format-list and M5 depth checks now walk their chains the same way. M5 and G17S only.Testing (host):
hk_g17p_compression_testpasses all 4069 checks.hk_image.c,hk_cmd_draw.candhk_g17p_meta_copy_core.cbuild with-Dwerror=true.