Skip to content

Fix pixel card shape isolation - #105

Merged
austin-smith merged 1 commit into
mainfrom
fix-pixel-shape-isolation
Sep 15, 2026
Merged

austin-smith merged 1 commit into
mainfrom
fix-pixel-shape-isolation

Conversation

@austin-smith

Copy link
Copy Markdown
Owner

What Changed

Mark PixelCardShape as nonisolated so its geometry methods satisfy SwiftUI’s Shape and InsettableShape requirements.

Why

Fix compilation with Xcode 27 when the project defaults to main-actor isolation. The shape operates entirely on value-based geometry, so it does not require the main actor.

Validation

  • macOS and iOS Simulator Debug builds passed with the shape fix.
  • Focused project-configuration tests passed after the final project changes.
  • Structured code review and diff checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T22:37:18.031232Z ccff879 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@austin-smith
austin-smith merged commit aa91d76 into main Sep 15, 2026
3 checks passed
@austin-smith
austin-smith deleted the fix-pixel-shape-isolation branch September 15, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant