Icon set hygiene: resolvable filenames + uniform sizes (#3) - #8
Merged
Merged
Conversation
All nine capitalised files in roster_classes/ were unreachable: the roster grid builds roster_classes/<imagename>.png from the installer's value, which is lowercase for every class (lotro_burglar, lotro_captain, …). Renaming them fixes the grid icon for 9 of the 19 classes. The remaining 10 (beorning, blackarrow, brawler, defiler, mariner, reaver, stalker, unknown, warleader, weaver) have no roster artwork at all, and the class-icon size normalisation is still outstanding, so #3 stays open. Refs #3 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Class icons shipped as a 20/38/43/48 mix and race icons as a 20/32/48 mix. The roster renders these at their natural size with no width/height attributes, so the odd ones out misaligned their rows. Both sets are normalised to 48x48 by centring each icon on a transparent canvas rather than upscaling: original pixels stay crisp and the change is reversible, at the cost of the 20x20 sources (beorning, highelf, stoutaxe) still reading smaller than the rest. Real 48x48 art is still the better fix for those three. test_class_images_are_all_48x48 / test_race_images_are_all_48x48 guard both sets from here on. Still open on #3: lotro_brawler / lotro_mariner / lotro_unknown class icons, lotro_hobbit_river race icon, and the 10 classes with no roster_classes artwork. Refs #3 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
avandenberghe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3 — two of the issue's parts. Kept open for the missing artwork.
1. Roster grid filenames (commit 1)
All nine capitalised files in
roster_classes/were unreachable: the roster grid buildsroster_classes/<imagename>.pngfrom the installer's value, which is lowercase for every class (lotro_burglar,lotro_captain, …). Renaming them fixes the grid icon for Beorning, Burglar, Captain, Champion, Guardian, Hunter, Lore-master, Minstrel and Rune-keeper.This wasn't in the issue text — #3 describes the
class_images/size mix — but it's the same defect class, found while auditing the icon sets.2. Icon sizes (commit 2)
Class icons were a 20/38/43/48 mix; race icons a 20/32/48 mix. Both sets are normalised to 48x48 by centring each icon on a transparent canvas, not upscaling — the issue suggests 48x48 to match the largest existing icons, and padding gets there without the blur a 20→48 resample would introduce. Reversible, and the original pixels are untouched. Tradeoff: beorning, highelf and stoutaxe still read smaller than their neighbours, so real 48x48 art for those three remains worthwhile.
lotro_icon_dimensions_testnow guards both sets.Still open on #3
class_images/:lotro_brawler,lotro_mariner(both added by Update game data (classes, races, factions) #7 with no assets) andlotro_unknownrace_images/:lotro_hobbit_river(flagged in the issue comment); also an unreferencedlotro_man_bree.pngthat no seeded race points atroster_classes/: no artwork at all for blackarrow, brawler, defiler, mariner, reaver, stalker, unknown, warleader, weaverWith avathar/bbguild#389 merged, every one of those falls back to the
class_images/icon (or the game's unknown icon) instead of rendering broken.🤖 Generated with Claude Code