fix(setup): Update Physionet 2017 challenge download links#70
Open
HSTE21 wants to merge 1 commit intoawni:masterfrom
Open
fix(setup): Update Physionet 2017 challenge download links#70HSTE21 wants to merge 1 commit intoawni:masterfrom
HSTE21 wants to merge 1 commit intoawni:masterfrom
Conversation
### 🔨 Motivation The original download links used in `setup.sh` for the Physionet Challenge 2017 data were broken and failed to complete the script's execution. This prevented users from successfully setting up the necessary training and sample datasets. ### ✅ Changes This pull request updates the `setup.sh` file with the new, working, direct download URLs for the following files: * `training2017.zip` * `sample2017.zip` * `REFERENCE-v3.csv` The script now uses the direct `?download` links from PhysioNet, ensuring the setup process completes successfully. ### 🧪 Testing The updated `setup.sh` script was executed locally to confirm that: 1. The `data` directory is created. 2. All three files (`training2017.zip`, `sample2017.zip`, `REFERENCE-v3.csv`) are downloaded correctly. 3. The two zip files are successfully unzipped. 4. The script proceeds to the final step (`python build_datasets.py`) without errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔨 Motivation
The original download links used in
setup.shfor the Physionet Challenge 2017 data were broken and failed to complete the script's execution. This prevented users from successfully setting up the necessary training and sample datasets.✅ Changes
This pull request updates the
setup.shfile with the new, working, direct download URLs for the following files:training2017.zipsample2017.zipREFERENCE-v3.csvThe script now uses the direct
?downloadlinks from PhysioNet, ensuring the setup process completes successfully.🧪 Testing
The updated
setup.shscript was executed locally to confirm that:datadirectory is created.training2017.zip,sample2017.zip,REFERENCE-v3.csv) are downloaded correctly.python build_datasets.py) without errors.