Add GO111MODULE=on to honnef.co staticcheck - #3193
Merged
prateekchaudhry merged 1 commit intoApr 28, 2022
Merged
Conversation
sparrc
approved these changes
Apr 28, 2022
fierlion
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some static checks are failing when creating PRs to this repo. In particular, make get-deps-init step fails, example https://github.com/aws/amazon-ecs-agent/runs/6186432720?check_suite_focus=true#step:6:6
The make target was recently added and the prefix
GO111MODULE=onwas missed during the addition. This PR fixes this and makes this step similar to the one inget-depstargetTesting
Creating a PR and checking the static checks pass (see checks in prateekchaudhry#16 , or the checks in this PR)
New tests cover the changes: No
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.