Add ML-DSA x86_64 native assembly to CC builder scripts#1110
Merged
Conversation
Add discovery of ML-DSA mldsa-native x86_64 assembly files in the CC builder scripts for linux-x86_64 and apple-x86_64, matching the existing pattern used for ML-KEM. This is needed once aws-lc imports the mldsa-native x86_64 backend (aws/aws-lc#3195). Signed-off-by: Jake Massimo <jakemas@amazon.com>
WillChilds-Klein
left a comment
WillChilds-Klein
left a comment
There was a problem hiding this comment.
do we not need similar updates to the windows x86_64 script?
Contributor
Author
|
No — the Windows script ( |
geedo0
approved these changes
Apr 29, 2026
WillChilds-Klein
approved these changes
Apr 29, 2026
justsmth
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux_x86_64.shandapple_x86_64.shContext
aws/aws-lc#3195 imports the mldsa-native x86_64 AVX2 backend into aws-lc, adding
.Sfiles undercrypto/fipsmodule/ml_dsa/mldsa/native/x86_64/src/. Theaws-lc-rsCC builder needs to discover these files, otherwise theaws-lc-rs-linuxCI job in aws-lc fails. This PR unblocks aws/aws-lc#3195.This is the same pattern used when ML-KEM's x86_64 backend was first added.
Changes
linux_x86_64.sh: Addfindfor ML-DSA x86_64 assemblyapple_x86_64.sh: Addfindfor ML-DSA x86_64 assemblyNote
The generated
.rsbuilder files will need regeneration after the aws-lc submodule is bumped to include the ML-DSA native backend.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.