fix(windows): allow modifier key repeat - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by @inayayousfi, typed by GPT-5.6 Sol running in OpenCode.
Every call here is @inayayousfi's, and no agent acted on its own.
Summary
Allow Windows modifier keys to use backend-managed repeat when the caller passes
repeat=true. This keeps long-lived modifier holds active with the user's Windows keyboard delay and speed settings.Update the native repeat-state test and consumer documentation to cover modifier repeat and release cleanup.
Validation
python build.py test