Skip to content

fix(windows): allow modifier key repeat #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inayayousfi merged 1 commit into from
Aug 18, 2026
Merged

fix(windows): allow modifier key repeat #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/consumers/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ Example:
again before starting new repeated holds.
- On Linux/uinput, this flag does not change the existing backend behavior.
- On Windows, repeated keys are tied to the key/modifier mapping resolved by
the original `key_down(..., true)` call. Modifier-only holds do not repeat.
Multiple non-modifier keys may repeat simultaneously.
the original `key_down(..., true)` call. Modifier keys follow the same
opt-in repeat behavior. Multiple keys may repeat simultaneously.
- `axidev_io_keyboard_release_all_modifiers()` cancels active Windows emulated
repeats before releasing modifiers.
- Repeated synthetic Windows events may be observed by the global listener.
Expand Down
18 changes: 1 addition & 17 deletions src/keyboard/sender/sender_windows.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,22 +223,6 @@ static void axidev_io_windows_repeat_remove_cancelled_locked(
}
}

static bool axidev_io_windows_key_is_modifier(axidev_io_keyboard_key_t key) {
switch (key) {
case AXIDEV_IO_KEY_SHIFT_LEFT:
case AXIDEV_IO_KEY_SHIFT_RIGHT:
case AXIDEV_IO_KEY_CTRL_LEFT:
case AXIDEV_IO_KEY_CTRL_RIGHT:
case AXIDEV_IO_KEY_ALT_LEFT:
case AXIDEV_IO_KEY_ALT_RIGHT:
case AXIDEV_IO_KEY_SUPER_LEFT:
case AXIDEV_IO_KEY_SUPER_RIGHT:
return true;
default:
return false;
}
}

static uint64_t axidev_io_windows_monotonic_time_ns(void) {
return axidev_io_monotonic_time_ms() * 1000000ull;
}
Expand Down Expand Up @@ -723,7 +707,7 @@ axidev_io_result axidev_io_keyboard_sender_key_down_internal(
return result;
}

if (!repeat || axidev_io_windows_key_is_modifier(resolved_key)) {
if (!repeat) {
result = axidev_io_keyboard_sender_hold_modifier_internal(mods);
if (result != AXIDEV_IO_RESULT_OK) {
return result;
Expand Down
3 changes: 2 additions & 1 deletion tests/test_c_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,10 @@ static void test_windows_repeat_state(void) {
(axidev_io_keyboard_key_with_modifier_t){AXIDEV_IO_KEY_SHIFT_LEFT,
AXIDEV_IO_MOD_NONE},
true));
TEST_CHECK_EQ_INT((int)axidev_io_windows_sender_repeat_count_for_tests(), 0);
TEST_CHECK_EQ_INT((int)axidev_io_windows_sender_repeat_count_for_tests(), 1);
TEST_CHECK(axidev_io_keyboard_key_up((axidev_io_keyboard_key_with_modifier_t){
AXIDEV_IO_KEY_SHIFT_LEFT, AXIDEV_IO_MOD_NONE}));
TEST_CHECK_EQ_INT((int)axidev_io_windows_sender_repeat_count_for_tests(), 0);

TEST_CHECK(axidev_io_keyboard_key_down(
(axidev_io_keyboard_key_with_modifier_t){AXIDEV_IO_KEY_A,
Expand Down
Loading