Conversation
Core moves rated arena teams out of the faction premade lists into BG_QUEUE_RATED_ARENA, so the rated list read from the premade lists comes back empty. Read the rated bucket instead. It holds nothing else, so the IsRated filter goes too. Also stop the battleground cache walking the arena queue types. They have no premade or normal entries to list, and their rated teams come from UpdateArenaRated. Requires the core change that adds BG_QUEUE_RATED_ARENA.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
espkk
marked this pull request as ready for review
September 7, 2026 20:05
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core moves rated arena teams out of the faction premade lists into BG_QUEUE_RATED_ARENA, so the rated list read from the premade lists comes back empty. Read the rated bucket instead. It holds nothing else, so the IsRated filter goes too.
Also stop the battleground cache walking the arena queue types. They have no premade or normal entries to list, and their rated teams come from UpdateArenaRated.
Requires azerothcore/azerothcore-wotlk#27548