Skip to content

fix: list rated arena teams from the rated arena bucket #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
espkk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: list rated arena teams from the rated arena bucket #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions src/QueueListCache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,19 +78,13 @@ void QueueListCache::UpdateArenaRated()
if (bgQueue.IsAllQueuesEmpty(bracketID))
continue;

for (uint8 ii = BG_QUEUE_PREMADE_ALLIANCE; ii <= BG_QUEUE_PREMADE_HORDE; ii++)
for (auto const& itr : bgQueue.m_QueuedGroups[bracketID][BG_QUEUE_RATED_ARENA])
{
for (auto const& itr : bgQueue.m_QueuedGroups[bracketID][ii])
{
if (!itr->IsRated)
continue;

ArenaTeam* team = sArenaTeamMgr->GetArenaTeamById(itr->ArenaTeamId);
if (!team)
continue;
ArenaTeam* team = sArenaTeamMgr->GetArenaTeamById(itr->ArenaTeamId);
if (!team)
continue;

queueArenaRatedList.emplace_back(team->GetName(), itr->ArenaType, itr->ArenaTeamRating);
}
queueArenaRatedList.emplace_back(team->GetName(), itr->ArenaType, itr->ArenaTeamRating);
}
}
}
Expand Down Expand Up @@ -248,7 +242,9 @@ void QueueListCache::UpdateBg()
AddCacheToVector(queueCacheList, groupInfo, &bgQueue, bracket);
};

for (uint32 qtype = BATTLEGROUND_QUEUE_AV; qtype < MAX_BATTLEGROUND_QUEUE_TYPES; ++qtype)
// Battleground queue types only. The arena types above them have no premade or normal
// faction buckets to cache, and their rated teams are listed by UpdateArenaRated.
for (uint32 qtype = BATTLEGROUND_QUEUE_AV; qtype <= BATTLEGROUND_QUEUE_RB; ++qtype)
{
for (uint32 bracket = BG_BRACKET_ID_FIRST; bracket < MAX_BATTLEGROUND_BRACKETS; ++bracket)
{
Expand Down