Repository navigation
feat: add RDP V1 with IronRDP WASM and embedded Go gateway - #3
Merged
Merged
Conversation
azzliang6
marked this pull request as ready for review
September 12, 2026 08:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds RDP server records and desktop tabs alongside SSH while retaining single-binary deployment. Passwords are entered per connection and never stored or returned by the server API.
The Go gateway implements RDCleanPath, X.224 negotiation, NLA-required TLS, certificate chain or SHA256 pin verification, and bounded WebSocket/TLS forwarding. Dialing uses only the saved server ID. The UI provides username/domain, keyboard/mouse, fullscreen, dynamic resize, manual clipboard, isolated tabs and cancellation. Legacy records migrate to SSH; RDP rejects SSH/SFTP settings and stored credentials. See docs/rdp.md for setup and certificate instructions.
Validation: frontend typecheck/build and 31 tests pass; Go API/database/model tests, go vet and Windows build pass. Browser smoke verified WASM loading, real handshake reaching a saved local target, failure handling and multiple tabs. Mock TLS integration tests authentication, origin rejection, target binding, certificate policy, wire format, relay and cleanup. Also fixes Windows SQLite file-URI handling discovered during validation.
Draft pending real Windows NLA/desktop compatibility testing: no Windows target credentials were provided. Linux CI is fully green on 51ab663: all 31 frontend tests, typecheck/build, Go formatting, go vet, full go test -race ./..., binary build and Docker build passed. Run: https://github.com/azzliang6/opsup/actions/runs/34683751111 . Local Windows-only POSIX permission/chown failures do not occur in Linux CI. Audio, file/drive/printer/USB redirection, SSH jump RDP and KDC proxy configuration are outside V1.