Skip to content

Make each run's copy of the seed writable before the app starts - #12

Open
femto wants to merge 1 commit into
basecamp:mainfrom
femto:writable-seed
Open

femto wants to merge 1 commit into
basecamp:mainfrom
femto:writable-seed

Conversation

@femto

@femto femto commented Nov 5, 2026 •

Copy link
Copy Markdown

The app images run as uid 1000. On a host whose user has another uid, such as a GitHub Actions runner (uid 1001), each run's copy of the seed belongs to that user, so the app cannot open its database for writing and exits at startup. The existing chmod -R a+rwX through docker exec runs only once the app is up, which it never is there; the Rust image, for one, stops with "attempt to write a readonly database".

This makes the copy readable and writable by everyone (a+rwX: files read/write, directories also searchable) right after prepare_storage, before the container starts. On a host whose user is uid 1000 nothing changes.

Checked: bin/check passes. With this change, bin/benchmark --apps rust completes on ubuntu-latest; without it, Rust fails to start there.

The images run as uid 1000; where the host user is another (a CI runner,
uid 1001), the app could not open the database for writing and exited
before the harness made it writable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 5, 2026 08:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are reported for the benchmark storage-permission change.

No open issues 🎉

What changed in this PR

This PR makes each benchmark run’s seed copy writable before the app starts, preventing database startup failures when the host user’s UID differs from the app’s UID 1000.

Changes:

  • Applies a+rwX recursively to the prepared runtime storage before container startup.
  • Adds a comment explaining the host/container UID mismatch.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
bench/​compare.rb Makes per-run seed storage readable and writable before app startup.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants