Repository navigation
Conversation
The images run as uid 1000; where the host user is another (a CI runner, uid 1001), the app could not open the database for writing and exited before the harness made it writable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approved
No active review issues are reported for the benchmark storage-permission change.
No open issues 🎉
What changed in this PR
This PR makes each benchmark run’s seed copy writable before the app starts, preventing database startup failures when the host user’s UID differs from the app’s UID 1000.
Changes:
- Applies
a+rwXrecursively to the prepared runtime storage before container startup. - Adds a comment explaining the host/container UID mismatch.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
bench/compare.rb |
Makes per-run seed storage readable and writable before app startup. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app images run as uid 1000. On a host whose user has another uid, such as a GitHub Actions runner (uid 1001), each run's copy of the seed belongs to that user, so the app cannot open its database for writing and exits at startup. The existing
chmod -R a+rwXthroughdocker execruns only once the app is up, which it never is there; the Rust image, for one, stops with "attempt to write a readonly database".This makes the copy readable and writable by everyone (
a+rwX: files read/write, directories also searchable) right afterprepare_storage, before the container starts. On a host whose user is uid 1000 nothing changes.Checked:
bin/checkpasses. With this change,bin/benchmark --apps rustcompletes onubuntu-latest; without it, Rust fails to start there.