Repository navigation
admin-ui: surface preset save field errors inline - #95
Merged
Merged
Conversation
Co-Authored-By: opencode
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89
Summary
Preset saves in the Custom Client dialog now surface server validation field errors the same way build-record creation does, instead of showing only
Request failed with status code 400.saveCurrentAsPresetsnapshots the submitted fields and routes rejectedcustom_preset/createresponses through the existingreportCreateBuildFailure→applyServerFieldErrorspipeline, sopass_approve_mode/incompatiblerenders as the localized inline error with focus, scroll, and ARIA.custom_preset/createsetsuseServerErrorMessage: true, so the toast shows the server envelope message rather than the raw axios text.custom_json/permanent_passwordand theapi-tokenheader).Scope is UI-only; the backend already returns the required
data.fieldsenvelope.Validation
node --test tests/custom-client-validation.test.mjs— 72/72 passnpm run build— passgit diff --check— cleanuseServerErrorMessageassertion is source-level, and the inline/ARIA path is behaviorally tested).Manual verification
/admin/(cachedindex.html).