Repository navigation
basou: Name the keys a kind takes when a board refuses one, point the guide at the reference, draw a string measure without its unit, and give each record its own time - #376
Merged
Conversation
… guide at the reference, draw a string measure without its unit, and give each record its own time
…old, list records by a UTC recorded_at off regular files only, and test the anchor and the newest shape
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from two evaluations of
basou boardatboard_version3 (0.71.1) on boards outside basou. No shape changes: noboard_version,record_versionor method version moves, and no key is added toboard.yamlor to a record.observe[0]: unknown keys 'count', 'capture' (kind 'http' takes: key, kind, url, words, count_pattern, capture_pattern, notes). Both evaluations had to find the keys ofhttp,github_check,file_nameandtotalby guessing from one refusal after another; one approved a declaration that readwordsas a count.basou board guidepoints to the reference for its own version (docs/spec/board.mdat the version's tag), in step 2b (axis review) and in step 3 for a workspace with no board. Nothing basou printed named those keys.latest README.md, notlatest README.md name). A number keeps its unit, and so does the count of afile_paths.unitstays required.recorded_at. The board page's list of records and the last record inbasou board guidegave the time of the record's file name, which for a record written before 0.70.1 differs from itsrecorded_at(as the page's heading shows) by a second or so. The list readsrecorded_atoff the head of each regular file, only in the UTC form basou writes, and falls back to the name's time.basou board recordnow takesrecorded_atafter it measures the board again, not a few milliseconds before.docs/spec/board.md and the
Unreleasedsection of CHANGELOG.md say the same.Verification
pnpm install --frozen-lockfile,pnpm -r build,pnpm typecheck,pnpm lint,pnpm lint:lang,pnpm lint:paths,pnpm testandpnpm test:scriptsall exit 0 (core 2921 passed and 1 skipped, sdk 67, cli 1566, scripts 21).kindin a section or a lane); the reference line in both guide modes; string and number units inboard measureand on the page; the list of records with pretty and compact JSON, a nested or misplacedrecorded_at, non-UTC forms, a file that cannot be read and a link named as a record;recorded_ataftermeasured_at..git: 16 mutations of the author's own (15 caught, 1 equivalent) and the survivors of the review's own 32 (all caught after the second commit, or equivalent).