Repository navigation
Conversation
Bring this Slack message-deletion CLI up to the current toolchain: - Drop Python 2 support and cruft: remove the handle_encoding shim and .travis.yml (with its 2.7 job), switch to f-strings, lazy %-logging, timezone-aware datetimes, and operator.itemgetter. - Add full type annotations and pass pyright strict; the dynamic slacker client surface is described with local Protocols and a single cast. - Split the implementation into deslackify.cli so the package __init__ only re-exports, and rename RetryException to RetryError. - Replace setup.py/setup.cfg/MANIFEST.in with a hatchling + hatch-vcs pyproject.toml (tag-driven versioning), keeping the deslackify console entry point. - Expand the test suite (rate-limit retries, pagination, dry-run, error counting) and move it under tests/. - Add GitHub Actions CI (lint + 3.10-3.14 matrix) and a tag-driven trusted-publishing workflow; add a pre-commit config (codesorter, ruff ALL, docstrfmt, pyright, ...). - Update the README install instructions to use uv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this Slack message-deletion CLI up to the current toolchain (matching the recent
extended_http_server/flask-image-uploaderoverhauls), unblocking CodeSorter (which requires Python ≥3.10).Highlights
handle_encodingshim and.travis.yml(with its 2.7 job); switched to f-strings, lazy%-logging, timezone-aware datetimes, andoperator.itemgetter.pyrightstrict clean. The dynamicslackerclient surface is described with localProtocols and a singlecast(slacker stays as the dependency — it still imports and works on 3.10–3.14; swapping toslack_sdkwould be a separate, untestable rewrite).deslackify.cliso__init__only re-exports;RetryException→RetryError.setup.py/setup.cfg/MANIFEST.in→ hatchling + hatch-vcspyproject.toml(tag-driven versioning), keeping thedeslackifyentry point.tests/.ALL, docstrfmt, pyright, …).Tests pass on 3.10 and 3.14 locally; pre-commit is clean.