Conversation
|
please ignore the first commit, messed something up. second commit should be good for review. |
|
@florianbepunkt why there are 23 files marked as changed when there were actually only 2 changed? I think it could be a line ending change, but not sure. Are you using some git client? Please correct the issue, or open a new PR with only the changes you meant to do. |
|
@dciccale using the github desktop client on mac os, so yes, probably a line ending issue. I'll try to correct it when I have more time but it may be a while I'm afraid |
|
Looks like it's related to file permissions that were 644 and was replaced with 777 when commited. |
|
@florianbepunkt Thank you for your work, the code works very well in my implementation! I hope this PR can be merged eventually, because now we have to resort to linking a github repo in the |
fixes mws.FulfillmentOutboundShipment.CreateFulfillmentOrder(), moved the parameter conversion necessary for FBA into the request function