Fix Fulfillment and eliminate "complex" parameters#98
Open
nolanamy wants to merge 9 commits intobeardon:masterfrom
Open
Fix Fulfillment and eliminate "complex" parameters#98nolanamy wants to merge 9 commits intobeardon:masterfrom
nolanamy wants to merge 9 commits intobeardon:masterfrom
Conversation
...querystring fails to encode: ! * ' ( )
|
@nolanamy Looks good for me. One small thing though… for createFullfillmentOrder could you also add the MarketplaceId param (see here http://docs.developer.amazonservices.com/en_DE/fba_outbound/FBAOutbound_CreateFulfillmentOrder.html) If you use multi-channel fulfillment in multiple countries with marketplace inventory you need to specify the maketplace id in order to sucessfully place a fulfillment order. |
Author
|
@florianbepunkt Added optional |
jordankilburn
approved these changes
Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67.
So, clearly the "complex" parameter thing is overly complex...
This gets fulfillment working, uses a much simpler approach to list-of-object parameters, and standardizes fulfillment parameter names a bit. Also improves error handling and messages for both missing and unknown parameters, including for list and list-of-object types.
I successfully tested
ListInventorySupply,GetFulfillmentPreview,CreateFulfillmentOrder,ListAllFulfillmentOrders, andGetFulfillmentOrderwith a live FBA account.Thanks to forks: