Implement soorten filter inside sql query - #150
Open
wandernauta wants to merge 2 commits into
Open
Conversation
This moves checking the 'soort' of search results inside the search SQL query, as suggested in berthubert#141, so before the SQLite LIMIT rather than after. SearchHelper is modified to support the 'soort' parameter. Care is taken to closely follow the behavior of the existing 'categories' parameter (for example, default value = empty set = all soorten). As before, we look in the "meta" database for the value. The advantage of this is that the index database does not need to change. An alternative approach would be to add the 'soort' value to the docsearch table.
wandernauta
commented
Aug 18, 2026
| categories.insert("Activiteit"); | ||
| } else if(soorten=="moties") { | ||
| categories.insert("Document"); | ||
| sorts.insert("Motie"); |
Contributor
Author
There was a problem hiding this comment.
Hier moet misschien ook bij: Motie (gewijzigd/nader). Of anders gedocumenteerd waarom die er niet bij moeten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves checking the 'soort' of search results inside the search SQL
query, as suggested in #141, so before the SQLite LIMIT rather than
after.
SearchHelper is modified to support the 'soort' parameter. Care is taken
to closely follow the behavior of the existing 'categories' parameter
(for example, default value = empty set = all soorten).
As before, we look in the "meta" database for the value. The advantage
of this is that the index database does not need to change. An
alternative approach would be to add the 'soort' value to the docsearch
table.
This PR also contains the changes from #149.