Skip to content

Fix typos - #3291

Open
PrivacyIsARight wants to merge 3 commits into
beyond-all-reason:masterfrom
PrivacyIsARight:fix-typos
Open

Fix typos#3291
PrivacyIsARight wants to merge 3 commits into
beyond-all-reason:masterfrom
PrivacyIsARight:fix-typos

Conversation

@PrivacyIsARight

Copy link
Copy Markdown

There should be no functional changes in here, just comment / display string typo fixes. All of these were found by codespell.

@sprunk

sprunk commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

I don't know, nobody was too unhappy about those and it's just going to pollute git blame.

The ones visible outside the source and supposed to be read by users (springsetting descriptions, logs) are probably alright to fix though.

@PrivacyIsARight

Copy link
Copy Markdown
Author

I don't know, nobody was too unhappy about those and it's just going to pollute git blame.

The ones visible outside the source and supposed to be read by users (springsetting descriptions, logs) are probably alright to fix though.

Would .git-blame-ignore-revs be useful here?

@PrivacyIsARight

Copy link
Copy Markdown
Author

@sprunk I added the .git-blame-ignore-revs file.

@Beherith Beherith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through them, seem mostly sane, the lack of apostrophe's didnt bother me previously either. Saw a bunch of my own comments among the worst offenders.

@lostsquirrel1

Copy link
Copy Markdown
Collaborator

@sprunk are you happy with this and the git-blame-ignore-revs? The file will need correcting post merge to match to squash-merged commit hash.

@sprunk

sprunk commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

I don't mind. Perhaps use rebase rather than squash so it doesn't need fixing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants