fix: missing explicit death type when deleting a finished unit - #3310
Open
efrec wants to merge 1 commit into
Open
fix: missing explicit death type when deleting a finished unit#3310efrec wants to merge 1 commit into
efrec wants to merge 1 commit into
Conversation
weaponDefID 0 is a real weapondef and not an envDamageType, but is used in CUnitHandler::QueueDeleteUnit as a fallback/default. Reaching deletion through deathScriptFinished probably should use the script kill weapon instead. This does change what UnitDestroyed reports for some code paths, and drops the default argument on KillUnit and ForcedKillUnit, probably correct to do but needs to be careful.
Collaborator
|
Should be a new magic value probably, something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
weaponDefID 0 is a real weapondef and not an envDamageType, but is used in CUnitHandler::QueueDeleteUnit as a fallback/default. Reaching deletion through deathScriptFinished probably should use the script kill weapon instead.
This does change what UnitDestroyed reports for some code paths, and drops the default argument on KillUnit and ForcedKillUnit, probably correct to do but needs to be careful.