Refactor asio API usage to no longer use deprecated interfaces - #3313
Open
0x12A01DC wants to merge 2 commits into
Open
Refactor asio API usage to no longer use deprecated interfaces#33130x12A01DC wants to merge 2 commits into
0x12A01DC wants to merge 2 commits into
Conversation
Migrate from `asio::io_service` to `asio::io_context`, adapt new `resolver` method signatures and return types, and use `asio::mutable_buffer` `asio::mutable_buffers_1`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from
asio::io_servicetoasio::io_context, adapt newresolvermethod signatures and return types, and use
asio::mutable_bufferinstead ofasio::mutable_buffers_1.This makes the Recoil engine code compatible with the new Networking TS compatible API https://think-async.com/Asio/asio-1.38.2/doc/asio/net_ts.html. With these changes in-place it would be possible to update the asio library to version 1.38.2 from 1.30.2 without further changes to engine code