fix(tests): cleanup failures are reported, never swallowed silently - #70
Merged
Conversation
The previous fix narrowed the catch types and left the bodies empty — trading cs/catch-of-all-exceptions for cs/empty-catch-block, which is the same defect wearing a different rule id. An empty catch discards the one piece of evidence anyone debugging a full temp disk would need. House rule, now standing: no empty catch blocks anywhere, tests included. A caught exception is accounted for or it is not caught. Cleanup failure here writes the leftover path and the reason to the test error output; the run still passes, because a temp directory surviving is survivable — invisibly surviving is not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix narrowed the catch types and left the bodies empty — trading
cs/catch-of-all-exceptionsforcs/empty-catch-block. Same defect, different rule id.House rule, now standing: no empty catch blocks anywhere, tests included. A caught exception is accounted for or it is not caught.
The cleanup catch now writes the leftover directory and the reason to test error output. The run still passes — a temp directory surviving is survivable; invisibly surviving is not. Repo swept for other empty catches: none.
Clears the last 2 open code-scanning alerts (#57, #58).