Skip to content

fix(tests): cleanup failures are reported, never swallowed silently #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgard68 merged 1 commit into from
Aug 24, 2026
Merged

fix(tests): cleanup failures are reported, never swallowed silently #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions tests/DevSecOpsSentinel.Infrastructure.Tests/GitHubInstallationTokenProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,17 +145,18 @@ await Assert.ThrowsAsync<InvalidOperationException>(

public void Dispose()
{
// Best-effort cleanup of the per-test key directory; only the failures a
// filesystem delete can actually produce are worth swallowing.
// Best-effort cleanup of the per-test key directory. A failure must not fail
// the test run, but it is never silent: the leftover path and the reason go to
// the test output, because an empty catch discards the one piece of evidence
// anyone debugging a full temp disk would need.
try
{
Directory.Delete(_keyDirectory, recursive: true);
}
catch (IOException)
{
}
catch (UnauthorizedAccessException)
catch (Exception exception) when (exception is IOException or UnauthorizedAccessException)
{
Console.Error.WriteLine(
$"Test cleanup left '{_keyDirectory}' behind: {exception.Message}");
}
}
}