DEP: drop mpmath as a depdendency, replaced with scipy - #13
Open
neutrinoceros wants to merge 1 commit into
Open
Conversation
neutrinoceros
force-pushed
the
dep/rm-mpmath
branch
from
March 4, 2026 16:17
e044c6b to
c8589ef
Compare
Contributor
Author
|
update: the warning I saw earlier only appears when using |
neutrinoceros
marked this pull request as ready for review
March 4, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the correct replacement. However, I note that in my experiments with it, I hit some warnings in numpy, triggered from scipy:
suggesting that scipy is maybe not solving correctly in the complex domain, or at the very least that it's doing something weird with numpy's API. I can probably dig it down further there, and I'll keep this PR as a draft until then.