Skip to content

DEP: drop mpmath as a depdendency, replaced with scipy #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neutrinoceros wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DEP: drop mpmath as a depdendency, replaced with scipy #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dsharp_opac/dsharp_opac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1423,7 +1423,8 @@ def nk(self, lam):
k : float
: imaginary part of mixed optical property
"""
from mpmath import findroot
from scipy.optimize import newton

l_arr = np.array(lam, ndmin=1)
eps_mean = np.empty(np.shape(l_arr)).astype('complex')

Expand All @@ -1439,7 +1440,7 @@ def nk(self, lam):
#
def fct(x):
return sum(self.abundances * ((eps - x) / (eps + 2 * x)))
eps_mean[i] = complex(findroot(fct, complex(0.5, 0.5)))
eps_mean[i] = newton(fct, x0=(0.5 + 0.5j))
elif self.rule.lower() == 'maxwell-garnett':
#
# kataoka et al. 2014, eq. 3
Expand Down
3 changes: 0 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ dependencies = [
"scipy>=1.13.0",
"matplotlib>=3.8.0",
"astropy>=7.0.0",

# only need mpmath.findroot, which I suspect scipy.optimize.fsolve can replace
"mpmath>=1.3.0",
]

[project.urls]
Expand Down