fix(ui): footer separators are lines, not frames - #416
Merged
Conversation
The footer's section dividers used `border-t border` — but bare `border` is a 1px border on ALL sides, so each divider rendered as a full gray frame around its block (visitor-reported on /contact). Keep only border-t. Note: the same `border-t border` idiom appears in 20+ other components; scoped here to the public footer where it was reported. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RmMktaYn8MuJdEqjp5gWU
Same bug class as the footer: `border-t border-b border` and `border-t border` render full frames (visitor-reported as "get rid of the gray area" on /en/blog). The intentional frames (success card, donate button outline) are untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RmMktaYn8MuJdEqjp5gWU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visitor feedback (FleetCrown inbox, evig /contact): "gray frames here are not needed impo. change immediately".
The footer's section dividers used
border-t border— bare Tailwindborderis a 1px border on ALL sides, so each divider block rendered as a full gray frame (verified live via getComputedStyle: 1px on all four sides on both flagged wrappers). Fixed by keeping onlyborder-ton the 4 sites inFooter.tsx.Class-wide note: the same
border-t border(andborder-b border) idiom appears in 20+ other components (BottomNav, BulkTable, HirnChatPanel, admin modals, NewsletterSignup, MessageThread, …). Left untouched here — each needs a visual judgment call about whether the frame is intended. Worth a follow-up sweep.🤖 Generated with Claude Code
https://claude.ai/code/session_018RmMktaYn8MuJdEqjp5gWU