Skip to content

fix(ui): footer separators are lines, not frames #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catomean merged 2 commits into from
Aug 31, 2026
Merged

fix(ui): footer separators are lines, not frames #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83d1471
fix(ui): footer separators are lines, not frames
catomean Aug 31, 2026
a7af528
fix(ui): blog newsletter box — top/bottom rules, not a frame
catomean Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/blog/NewsletterSignup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function NewsletterSignup() {

return (
<div className="max-w-[680px] mx-auto px-6 py-12">
<div className="border-t border-b border py-12">
<div className="border-t border-b py-12">
{/* Header */}
<div className="text-center mb-8">
<IconBadge icon={Mail} shape="circle" size="lg" className="mb-4" />
Expand Down Expand Up @@ -106,7 +106,7 @@ export default function NewsletterSignup() {
)}

{/* Community Support */}
<div className="mt-8 pt-8 border-t border text-center">
<div className="mt-8 pt-8 border-t text-center">
<div className="flex items-center justify-center gap-2 text-text-secondary mb-2">
<Heart className="w-5 h-5 text-error-500" />
<p className="text-sm">{t('communityTitle')}</p>
Expand Down
8 changes: 4 additions & 4 deletions src/components/layout/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function Footer() {
const tDivisions = useTranslations('divisions')

return (
<footer className="bg-surface-raised text-text-primary border-t border">
<footer className="bg-surface-raised text-text-primary border-t">
<div className="container mx-auto px-4 py-12">
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-4 gap-8">
{/* Brand Section */}
Expand Down Expand Up @@ -109,15 +109,15 @@ export default function Footer() {
</div>

{/* Newsletter */}
<div className="mt-10 pt-8 border-t border">
<div className="mt-10 pt-8 border-t">
<NewsletterSignup
source="footer"
/>
</div>

{/* Social Links — only when evig actually has profiles (see socialLinks) */}
{socialLinks.length > 0 && (
<div className="mt-8 pt-6 border-t border flex justify-center gap-4">
<div className="mt-8 pt-6 border-t flex justify-center gap-4">
{socialLinks.map((social) => (
<a
key={social.name}
Expand All @@ -134,7 +134,7 @@ export default function Footer() {
)}

{/* Legal Links — routes from ROUTES.public SSOT */}
<div className="mt-6 pt-6 border-t border">
<div className="mt-6 pt-6 border-t">
<nav aria-label={tFooter('legal')} className="flex flex-wrap justify-center gap-x-6 gap-y-2 text-xs text-text-tertiary">
<Link href={ROUTES.public.impressum} className="hover:text-text-primary transition-colors">
{tFooter('impressum')}
Expand Down
Loading