fix(nav): the sidebar highlighted the current page and never announced it - #74
Merged
Conversation
…d it Both the desktop sidebar loop and the mobile bottom tab bar called isActive() to paint nav-link-active / mobile-tab-item-active, and the desktop Settings link compared pathname directly — none of the three set aria-current, so the current page existed only for people who can see it. Zero occurrences of aria-current anywhere in the repo. .nav-link also came out near 41px (10px vertical padding around 14px text), just under the 44px touch floor this repo already states explicitly on .browse-chip. Says the floor now instead of leaving it to arithmetic. .mobile-tab-item was already comfortably above it. No visual change beyond the min-height. Found by the fleet nav-contract audit, which flags a repo whose navigation computes an active state and never announces it anywhere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XeELB8b3N4JrT2asYL9WvE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the desktop sidebar loop and the mobile bottom tab bar called
isActive()to paintnav-link-active/mobile-tab-item-active, and the desktop Settings link comparedpathnamedirectly — none of the three setaria-current. Zero occurrences anywhere in the repo..nav-linkalso came out near 41px (10px vertical padding around 14px text), just under the 44px touch floor this repo already states explicitly on.browse-chip. Now says the floor instead of leaving it to arithmetic that happened to land close..mobile-tab-itemwas already comfortably above it.No visual change beyond the
min-height.Verification
Typecheck clean, lint clean, 904 tests pass (88 files).
Found by the fleet nav-contract audit, which flags a repo whose navigation computes an active state and never announces it anywhere.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XeELB8b3N4JrT2asYL9WvE