Skip to content

fix(nav): the sidebar highlighted the current page and never announced it #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Aug 31, 2026
Merged

fix(nav): the sidebar highlighted the current page and never announced it #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,6 +925,10 @@ body {
display: flex;
align-items: center;
gap: 12px;
/* 10px vertical padding around 14px text landed near 41px — just under the
44px touch floor. min-height says the floor explicitly rather than
leaving it to arithmetic that happens to work today. */
min-height: 44px;
padding: 10px 12px;
border-radius: 12px;
font-size: 14px;
Expand Down
3 changes: 3 additions & 0 deletions components/portal/SidebarNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ export default function SidebarNav({ userName, userEmail, userRole, hasSeller, l
<Link
key={href}
href={href}
aria-current={isActive(pathname, href, match) ? "page" : undefined}
className={`nav-link ${isActive(pathname, href, match) ? "nav-link-active" : "nav-link-inactive"}`}
>
<Icon className="w-4 h-4 flex-shrink-0" />
Expand All @@ -155,6 +156,7 @@ export default function SidebarNav({ userName, userEmail, userRole, hasSeller, l
<LocaleSwitcher current={locale} />
<Link
href={PORTAL_ROUTES.settings}
aria-current={pathname === PORTAL_ROUTES.settings ? "page" : undefined}
className={`nav-link ${pathname === PORTAL_ROUTES.settings ? "nav-link-active" : "nav-link-inactive"}`}
>
<Settings className="w-4 h-4 flex-shrink-0" />
Expand Down Expand Up @@ -211,6 +213,7 @@ export default function SidebarNav({ userName, userEmail, userRole, hasSeller, l
<Link
key={href}
href={href}
aria-current={isActive(pathname, href, match) ? "page" : undefined}
className={`mobile-tab-item ${isActive(pathname, href, match) ? "mobile-tab-item-active" : "mobile-tab-item-inactive"}`}
>
<Icon
Expand Down
Loading