fix(nav): the in-page nav marked the current section for the eye only - #26
Merged
Conversation
The section nav tracks which section is in view via an IntersectionObserver and expressed that as `data-active`, which is a styling hook and nothing more. A screen-reader user got no signal about where in the page they were. `aria-current="location"`, not `"page"`: this is a one-page site and the nav tracks a SECTION, which is exactly what `location` means. Claiming `page` would announce a navigation that never happens here. No visual change — `data-active` still drives the styling. Found by the fleet nav-contract audit, which flags a repo whose navigation computes an active state and never announces it anywhere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XeELB8b3N4JrT2asYL9WvE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The section nav tracks which section is in view via an IntersectionObserver and expressed that as
data-active— a styling hook and nothing more. A screen-reader user got no signal about where in the page they were.aria-current="location", not"page": this is a one-page site and the nav tracks a section, which is exactly whatlocationmeans. Claimingpagewould announce a navigation that never actually happens here.No visual change —
data-activestill drives the styling.Verification
Typecheck clean, lint clean, 92 tests pass, formatting clean.
Found by the fleet nav-contract audit, which flags a repo whose navigation computes an active state and never announces it anywhere.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XeELB8b3N4JrT2asYL9WvE