Skip to content

fix(nav): the in-page nav marked the current section for the eye only #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Aug 31, 2026
Merged

fix(nav): the in-page nav marked the current section for the eye only #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion components/Nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,16 @@ export function Nav({ t, locale }: { t: Dictionary; locale: Locale }) {
<ul className={styles.links}>
{NAV_IDS.map((id) => (
<li key={id}>
<a href={`#${id}`} className={`micro ${styles.link}`} data-active={active === id}>
{/* `location`, not `page`: this is a one-page site and the nav
tracks which SECTION is in view, which is exactly what
aria-current="location" means. "page" would claim a
navigation that never happens here. */}
<a
href={`#${id}`}
className={`micro ${styles.link}`}
data-active={active === id}
aria-current={active === id ? 'location' : undefined}
>
{t.nav[id]}
</a>
</li>
Expand Down