UI: Added bonus time to Sleeves UI - #3082
Open
branchtheory wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making the bonus time more visible for improved player happiness. Personally I think that putting bonus time in More Stats is taking the 'the UI is deliberately clunky' thing a step too far.
Here's what it looks like:
Bonus time shows on the table even if it's 0s. I figured this was preferable to the tables getting bumped up and down the page when sleeves regain / run out of bonus time.
Similar to the current behaviour, if the bonus time is less than 2s, it shows 0s to prevent 0s/1s flickering.
Extracted from #3051 - too much scope creep.